Fix for the coredns configmap update: the corefile was not updated, e…#3378
Fix for the coredns configmap update: the corefile was not updated, e…#3378Tanzp01 wants to merge 2 commits intokubernetes:masterfrom
Conversation
…ven though a different cache size is set up in the test parameters.
k8s-ci-robot
added
the
cncf-cla: no
|
Welcome @Tanzp01! |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @Tanzp01. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/XS
|
You need to do the EasyCLA. |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
Hi, I have updated the necessary CLA, could you take a look? |
dns/py/params.py
Outdated
| if value > 0: | ||
| cf = inputs.configmap_yaml['data']['Corefile'] | ||
| cfList = cf.decode().split("\n") | ||
| # fix the cf type so that it works also for python3 |
There was a problem hiding this comment.
should we just update the code for Python 3? Isn't Python 2 deprecated?
There was a problem hiding this comment.
Thanks Bowei for the feedbacks! I have removed the line for python2, now only python3 supported for cleaner code
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
k8s-ci-robot
added
lifecycle/rotten
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
|
@k8s-triage-robot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/reopen |
|
@Tanzp01: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Tanzp01 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
4 participants
What type of PR is this?
Fix for bug
What this PR does / why we need it:
This change should fix the coredns configmap update, and enable the test can also be run on python3.
Which issue(s) this PR fixes:
Fixes - When test GKE DNS performance with the auto creation of dns-perf-server, the coredns configmap corefile was not updated even if different cache size was set as parameters.
Special notes for your reviewer: