capi: refactor to use shared nodeup builder #17703
Merged
+56
−229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/nodeup
area/provider/gcp
justinsb
changed the title
k8s-ci-robot
added
do-not-merge/work-in-progress
justinsb
force-pushed
the
clusterapi_controllers_refactor_nodeup
branch
from
3eb9c7f to
f8f1ee8
Compare
k8s-ci-robot
added
size/L
|
/test pull-kops-scenario-clusterapi-gcp |
justinsb
force-pushed
the
clusterapi_controllers_refactor_nodeup
branch
3 times, most recently
from
65b8a82 to
8d7d943
Compare
The intent is that the ConfigBuilder from bare-metal support is reusable.
justinsb
force-pushed
the
clusterapi_controllers_refactor_nodeup
branch
from
8d7d943 to
aa3e332
Compare
|
/test pull-kops-scenario-clusterapi-gcp |
|
/test pull-kops-scenario-clusterapi-gcp Hit the problem with calico not coming up, we've seen that a few times but it seems unrelated |
justinsb
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
Probably should have just done it this way in the first place, it's much less code! /assign @hakman |
|
Yup, totally agree. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #17636
Adds: