Skip to content

feat: Add support for azuredisk-csi-driver #17683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

feat: Add support for azuredisk-csi-driver #17683

wants to merge 11 commits into from

Conversation

@ThomasCardin
Copy link

@k8s-ci-robot k8s-ci-robot requested a review from hakman October 16, 2025 12:22
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 16, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @ThomasCardin!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 16, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @ThomasCardin. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 16, 2025
@ThomasCardin ThomasCardin changed the title feat: Add support for azuredisk-csi-driver wip: Add support for azuredisk-csi-driver Oct 16, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2025
hakman
hakman requested changes Oct 16, 2025
View reviewed changes
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ThomasCardin. Added some small initial suggestions.

@hakman
Copy link
Member

hakman commented Oct 16, 2025

/ok-to-test
/test pull-kops-e2e-kubernetes-azure

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 16, 2025
@hakman
Copy link
Member

hakman commented Oct 16, 2025

/test pull-kops-e2e-kubernetes-azure

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hakman. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ThomasCardin
Copy link
Author

I see here that there are several image versions (v1.33.5, v1.32.11, v1.31.12). Should I manage these versions like aws-ebs-csi-driver.addons.k8s.io does?

@hakman
Copy link
Member

hakman commented Oct 16, 2025

I see here that there are several image versions (v1.33.5, v1.32.11, v1.31.12). Should I manage these versions like aws-ebs-csi-driver.addons.k8s.io does?

Not in this stage. Just use the latest one.

@ThomasCardin
Copy link
Author

/retest

@hakman
Copy link
Member

hakman commented Oct 16, 2025 •
edited
Loading

@ThomasCardin the goal is to get this to pass, you can ignore the other failing tests for now:
/test pull-kops-e2e-kubernetes-azure

@ThomasCardin
Copy link
Author

/test pull-kops-e2e-kubernetes-azure

@ThomasCardin
Copy link
Author

/retest

@ThomasCardin ThomasCardin changed the title wip: Add support for azuredisk-csi-driver feat: Add support for azuredisk-csi-driver Oct 16, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2025
@ThomasCardin
Copy link
Author

/test pull-kops-e2e-kubernetes-azure

@ThomasCardin
Copy link
Author

/test pull-kops-e2e-kubernetes-azure

@ThomasCardin
Copy link
Author

/test pull-kops-e2e-kubernetes-azure

@ThomasCardin
Copy link
Author

/retest

@ThomasCardin
Copy link
Author

/test pull-kops-e2e-kubernetes-azure

@ThomasCardin
Copy link
Author

/test pull-kops-e2e-kubernetes-azure

@ThomasCardin
Copy link
Author

/test pull-kops-e2e-k8s-aws-calico

@ThomasCardin ThomasCardin requested a review from hakman October 17, 2025 12:27
@ThomasCardin
Copy link
Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hakman hakman Awaiting requested review from hakman

Assignees

@hakman hakman

Labels

area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for azuredisk-csi-driver

3 participants

@ThomasCardin @k8s-ci-robot @hakman