Skip to content

Extend openstack mock by misc. resources #17406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ascheman
Copy link

@ascheman ascheman commented May 14, 2025

  • Bump gophercloud and gopherclient both to v2.7.0
  • Add a referenced Flavor to a Server object
  • Enable to read Server Instance-Actions (just an empty list)
  • Enable to create FloatinIPs

Copy link

linux-foundation-easycla bot commented May 14, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 14, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @ascheman!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 14, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @ascheman. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested review from olemarkus and zetaab May 14, 2025 08:30
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 14, 2025
@hakman
Copy link
Member

hakman commented May 14, 2025

/ok-to-test
/cc @zetaab
/assign @zetaab

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zetaab. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 14, 2025
@ascheman ascheman marked this pull request as draft May 14, 2025 10:10
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2025
@ascheman ascheman force-pushed the fix/openstack-servers-flavor branch 4 times, most recently from 0a17afc to f627e1c Compare May 15, 2025 08:10
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 15, 2025
@ascheman ascheman force-pushed the fix/openstack-servers-flavor branch from 454fc18 to 1202c3b Compare May 15, 2025 08:44
@ascheman ascheman changed the title Add the referenced flavor to a new Server Extend openstack mock by misc. resources May 16, 2025
@ascheman ascheman marked this pull request as ready for review May 16, 2025 06:48
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2025
@k8s-ci-robot k8s-ci-robot requested a review from johngmyers May 16, 2025 06:49
@zetaab
Copy link
Member

zetaab commented May 22, 2025

@ascheman can you try to solve go module issues? something wrong with those. perhaps run go mod tidy

@ascheman ascheman force-pushed the fix/openstack-servers-flavor branch from 1202c3b to 3fe038a Compare May 26, 2025 08:36
@ascheman
Copy link
Author

@ascheman can you try to solve go module issues? something wrong with those. perhaps run go mod tidy

I have rebased to latest master, ran make gomod and force-pushed everything - hoping for the best 😬

@ascheman
Copy link
Author

@ascheman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-k8s-aws-amazonvpc 3fe038a link true /test pull-kops-e2e-k8s-aws-amazonvpc
pull-kops-e2e-k8s-gce-cilium 3fe038a link true /test pull-kops-e2e-k8s-gce-cilium
pull-kops-e2e-k8s-gce-ipalias 3fe038a link true /test pull-kops-e2e-k8s-gce-ipalias
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

/retest

These test errors resulted from a rate limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants