-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ephemeral S3 buckets for E2E tests #17157
base: master
Are you sure you want to change the base?
Use ephemeral S3 buckets for E2E tests #17157
Conversation
Use S3 buckets created during the lifecycle of a test instead of a static one.
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need a second bucket for the cluster's oidc discovery store, we can reuse this logic but it will need a policy that allows anonymous read access.
if err != nil { | ||
return "", fmt.Errorf("building AWS STS presigned request: %w", err) | ||
} | ||
bucket := "k8s-infra-kops-" + *aws.String(*callerIdentity.Account) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to add a random or timestamp suffix. S3 has a delay before a deleted bucket's name can be reused, and if a boskos account is quickly reused between kops jobs then the bucket creation could fail.
Use S3 buckets created during the lifecycle of a test instead of a
static one.