Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate IG NodeLabels to k8s nodes in Hetzner #16739

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented Aug 7, 2024

Fixes #16159

This adds Hetzner server labels for the instance group nodeLabels. kops-controller then recognizes these server labels and sets them on the associated k8s node.

I'm marking this WIP as we may need to change this approach due to label length limits in the Hetzner API:

https://docs.hetzner.com/cloud/servers/getting-started/creating-a-server/

Both key and value must be 63 characters or less, beginning and ending with an alphanumeric character and alphanumerics can be used inbetween

The Hetzner CCM mentions support for the node.kubernetes.io/exclude-from-external-load-balancers label included in the integration test output changes: hetznercloud/hcloud-cloud-controller-manager#182 (comment) which is 55 characters on its own, so with the prefix I've added it exceeds the length limit. I considered storing these elsewhere like in userdata and having kops-controller parse them out of the hcloud.Server's userdata, except hcloud doesn't expose userdata in read operations, it is a write-only field.

Therefore I think our only option is to use a shorter prefix

/wip

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/provider/hetzner Issues or PRs related to Hetzner provider labels Aug 7, 2024
@rifelpet
Copy link
Member Author

rifelpet commented Aug 7, 2024

/cc @hakman
any thoughts on how to best approach the length limit issue?

@k8s-ci-robot k8s-ci-robot requested a review from hakman August 7, 2024 03:43
upup/pkg/fi/cloudup/hetzner/cloud.go Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hakman. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rifelpet rifelpet changed the title WIP Propagate IG NodeLabels to k8s nodes in Hetzner Propagate IG NodeLabels to k8s nodes in Hetzner Aug 9, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 9, 2024
@hakman
Copy link
Member

hakman commented Aug 23, 2024

/test all

1 similar comment
@hakman
Copy link
Member

hakman commented Sep 14, 2024

/test all

@rifelpet
Copy link
Member Author

/retest

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 13, 2024
@hakman
Copy link
Member

hakman commented Dec 13, 2024

/test all

@hakman
Copy link
Member

hakman commented Dec 13, 2024

/retest

@k8s-ci-robot
Copy link
Contributor

@rifelpet: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-k8s-gce-cilium 99c8fb0 link true /test pull-kops-e2e-k8s-gce-cilium

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/hetzner Issues or PRs related to Hetzner provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ig nodeLabels not passed to kubernetes nodes in Hetzner
4 participants