Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sha256 for gcr.io/k8s-staging-etcd/etcd:3.5.17-0 #7655

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Fix sha256 for gcr.io/k8s-staging-etcd/etcd:3.5.17-0 #7655

merged 1 commit into from
Jan 2, 2025

Conversation

hakman
Copy link
Member

@hakman hakman commented Jan 2, 2025 •
edited
Loading

Previous PR used the ID instead of the digest #7632:

% crane digest gcr.io/k8s-staging-etcd/etcd:3.5.17-0
sha256:b4a9e4a7e1cf08844c7c4db6a19cab380fbf0aad702b8c01e578e9543671b9f9

time="10:01:05.811" level=error msg="edge {{gcr.io/k8s-staging-etcd true} {etcd 3.5.17-0} sha256:bd8b09267cb5db489d9c0e23df58bda39f8789b3941d1c6ee08ca65a94751be5 {us-west1-docker.pkg.dev/k8s-artifacts-prod/images/kubernetes k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com false} {etcd 3.5.17-0}}: skipping gcr.io/k8s-staging-etcd/etcd@sha256:bd8b09267cb5db489d9c0e23df58bda39f8789b3941d1c6ee08ca65a94751be5 because it is LOST (can't find it in src registry!)\n" diff=0s

/cc @cpanato @ahrtr

@k8s-ci-robot k8s-ci-robot requested review from ahrtr and cpanato January 2, 2025 10:38
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/release-eng Issues or PRs related to the Release Engineering subproject sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 2, 2025
@ahrtr
Copy link
Member

ahrtr commented Jan 2, 2025

/lgtm
/approve

Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, cpanato, hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2025
@k8s-ci-robot k8s-ci-robot merged commit c7ad766 into kubernetes:main Jan 2, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jan 2, 2025
@hakman hakman deleted the patch-5 branch January 2, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@ahrtr ahrtr Awaiting requested review from ahrtr

Assignees

@cpanato cpanato

@ahrtr ahrtr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
4 participants
@hakman @ahrtr @k8s-ci-robot @cpanato