Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image promotion for build-image v0.5.8 / v0.6.3 #7331

Closed

Conversation

haitch
Copy link
Contributor

@haitch haitch commented Sep 23, 2024

Image promotion for build-image v0.5.8 / v0.6.3
This is an automated PR generated from kpromo

kpromo pr --fork haitch --interactive --project build-image --tag v0.5.8 --tag v0.6.3

/xref: kubernetes/release#3738

/hold
cc: @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 23, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @haitch. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 23, 2024
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is missing the other archs like distroless-iptables-ppc64le / distroless-iptables-s390x

@haitch
Copy link
Contributor Author

haitch commented Sep 23, 2024

ah, I don't see how to configure kpromo to do that, do I have to manually update those?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: haitch
Once this PR has been reviewed and has the lgtm label, please ask for approval from cpanato. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 23, 2024
@haitch
Copy link
Contributor Author

haitch commented Sep 23, 2024

@haitch
Copy link
Contributor Author

haitch commented Sep 23, 2024

have to manually cross-check with following docker pull command, either I am not using kpromo tool correctly, or the tool need some update.

  • docker manifest inspect -v gcr.io/k8s-staging-build-image/distroless-iptables@sha256:7c961ad4732bddd1c8b7ede12027fbf9a7b2f3d750921faf6d7a74c894d81f7b

  • docker manifest inspect -v gcr.io/k8s-staging-build-image/distroless-iptables@sha256:f7d49886640191408cddc8aac6056c8a7957ba74eab88e95f1a69e207b3c3ef2

@haitch haitch requested a review from cpanato September 23, 2024 17:39
@jeremyrickard
Copy link
Contributor

ah, I don't see how to configure kpromo to do that, do I have to manually update those?

I don't believe that we need to specify anything for this. Can you share the kpromo version info?

Manually editing the manifests isn't something I think we want to do.

@haitch
Copy link
Contributor Author

haitch commented Sep 23, 2024

GitVersion: v4.0.5
GitCommit: unknown
GitTreeState: unknown
BuildDate: unknown
GoVersion: go1.21.3
Compiler: gc
Platform: linux/amd64

@haitch
Copy link
Contributor Author

haitch commented Sep 23, 2024

install from main, and retrying, closing this PR

@haitch haitch closed this Sep 23, 2024
@haitch haitch deleted the build-image-v0.5.8-image-promotion branch September 23, 2024 21:04
@haitch
Copy link
Contributor Author

haitch commented Sep 23, 2024

ah, I think I know the reason, I ran this kpromo tool too soon before the container image fully available from gcr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants