-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image promotion for build-image v0.5.8 / v0.6.3 #7331
Conversation
Signed-off-by: Haitao Chen <[email protected]>
Hi @haitch. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is missing the other archs like distroless-iptables-ppc64le
/ distroless-iptables-s390x
ah, I don't see how to configure kpromo to do that, do I have to manually update those? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: haitch The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cpanato have to do a manual edit, extract image hash from https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-release-push-image-distroless-iptables/1838117605244669952 |
have to manually cross-check with following docker pull command, either I am not using kpromo tool correctly, or the tool need some update.
|
I don't believe that we need to specify anything for this. Can you share the kpromo version info? Manually editing the manifests isn't something I think we want to do. |
GitVersion: v4.0.5 |
install from main, and retrying, closing this PR |
ah, I think I know the reason, I ran this kpromo tool too soon before the container image fully available from gcr. |
Image promotion for build-image v0.5.8 / v0.6.3
This is an automated PR generated from
kpromo
/xref: kubernetes/release#3738
/hold
cc: @kubernetes/release-engineering