-
Notifications
You must be signed in to change notification settings - Fork 8.4k
NGINX: Migrate auth cache key to NJS. #12447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
NGINX: Migrate auth cache key to NJS. #12447
Conversation
Hi @elizabeth-dev. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
@elizabeth-dev , you may want to look at this #12345 (comment) and adjust accordingly here |
400348c
to
387ea87
Compare
b9a7b81
to
0077427
Compare
/ok-to-test |
@strongjz I got this on my list of PRs I'd like to merge as soon as possible. But we first need to re-create the NJS module PR. It got merged once, but I reverted it. I also have this on my list. So overall: No worries, I'm handling this. 😁 |
0077427
to
40eee8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/triage accepted
/kind feature
/priority backlog
/hold
As this requires the NGINX NJS module in the NGINX base image, I'll first build and promote a new NGINX base image including NJS, include it on main
and LGTM this PR afterwards.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elizabeth-dev, Gacko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
40eee8c
to
b236414
Compare
b236414
to
d89d7ca
Compare
@elizabeth-dev We added NJS to the NGINX base image and included it on |
What this PR does / why we need it:
Migrate the Lua scripting code for calculating the auth cache key to NJS, maintaining the same behavior.
Depends on #12345 (change starts from that branch)
Types of changes
Which issue/s this PR fixes
Part of #12383
How Has This Been Tested?
The new implementation has been tested manually to verify that the result it produces matches the one in Lua, as well as passing the e2e test suite
Checklist: