Skip to content

KEP 1645: add ServiceImport conditions #5439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions keps/sig-multicluster/1645-multi-cluster-services-api/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -538,6 +538,11 @@ cluster, non-cluster-admin users should not be allowed to create or modify
`ServiceImport` resources. The mcs-controller should be solely responsible for
the lifecycle of a `ServiceImport`.

Some errors may occur during the `ServiceImport`'s lifecycle, such as IP protocol

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this new use case may impact the discussion on the the serviceImport api.

incompatibilities (i.e.: importing an IPv6 only service in an IPv4 cluster). These
errors and general status reporting of a `ServiceImport` should be reported
via its status conditions field.

For each exported service, one `ServiceExport` will exist in each cluster that
exports the service. The mcs-controller will create and maintain a derived
`ServiceImport` in each cluster within the clusterset so long as the service's
Expand Down Expand Up @@ -620,6 +625,12 @@ type ServiceImportStatus struct {
// +listType=map
// +listMapKey=cluster
Clusters []ClusterStatus `json:"clusters"`
// +optional
// +patchStrategy=merge
// +patchMergeKey=type
// +listType=map
// +listMapKey=type
Conditions []metav1.Condition `json:"conditions,omitempty" patchStrategy:"merge" patchMergeKey:"type"`
}

// ClusterStatus contains service configuration mapped to a specific source cluster
Expand All @@ -644,6 +655,11 @@ spec:
port: 80
sessionAffinity: None
status:
conditions:
- type: Ready
reason: Ready
status: "True"
lastTransitionTime: "2020-03-30T01:33:51Z"
clusters:
- cluster: us-west2-a-my-cluster
```
Expand Down