Skip to content

KEP-740: promote external token signing to beta #5323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

KEP-740: promote external token signing to beta #5323

wants to merge 1 commit into from

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented May 20, 2025

  • One-line PR description: Promote KEP-740 to beta
  • Other comments:
    • drops e2e test from graduation since integration test can exercise the surface area
    • drops externalization of legacy controller in staging repo (none of the known consumers of this feature would use the externalized controller code)

/sig auth
/cc @enj @micahhausler
cc @ahmedtd @HarshalNeelkamal

@k8s-ci-robot k8s-ci-robot requested review from enj and micahhausler May 20, 2025 21:55
@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels May 20, 2025
@liggitt
Copy link
Member Author

liggitt commented May 20, 2025

/cc @soltysh
for PRR

@k8s-ci-robot k8s-ci-robot requested a review from soltysh May 20, 2025 21:55
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 20, 2025
This was referenced May 20, 2025
Open
Open
@enj enj added this to SIG Auth May 21, 2025
@enj enj moved this to Needs Triage in SIG Auth May 21, 2025
soltysh
soltysh reviewed May 21, 2025
View reviewed changes
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 21, 2025
soltysh
soltysh approved these changes May 22, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
the PRR section

@github-project-automation github-project-automation bot moved this from Needs Triage to In Review in SIG Auth May 22, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@enj enj Awaiting requested review from enj

@micahhausler micahhausler Awaiting requested review from micahhausler

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Auth
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liggitt @k8s-ci-robot @soltysh