Skip to content

KEP-5307 Initial KEP for container restart policy #5308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

KEP-5307 Initial KEP for container restart policy #5308

wants to merge 1 commit into from

Conversation

yuanwang04
Copy link

  • One-line PR description: Initial KEP for container restart policy

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 16, 2025
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. labels May 16, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @yuanwang04!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 16, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @yuanwang04. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 16, 2025
SergeyKanzhelev
SergeyKanzhelev reviewed May 16, 2025
View reviewed changes
keps/sig-node/5307-container-restart-policy/README.md
we may need to implement as described here: https://github.com/kubernetes/enhancements/issues/3329#issuecomment-1571643421

```
restartPolicy: Never
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dchen1107 I remember you had a concern with having Never pod with the container inside it that has restart count increasing. How strong is this concern? Strong enough to iontroduce the restartPolicy: Custom?

@yuanwang04 yuanwang04 force-pushed the container-restart-policy branch from 6cb2b80 to 0cbfc18 Compare May 16, 2025 22:25
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yuanwang04
Once this PR has been reviewed and has the lgtm label, please assign johnbelamaric for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kannon92
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 18, 2025
@yuanwang04 yuanwang04 force-pushed the container-restart-policy branch from 0cbfc18 to 040ffef Compare May 19, 2025 21:45
kannon92
kannon92 reviewed May 20, 2025
View reviewed changes
keps/sig-node/5307-container-restart-policy/README.md
- name: myapp1
# the default behavior is inherited from the Pod’s restartPolicy
restartPolicy: Custom
# pod-level API for specifying container restart rules
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This API is at the container level it seems.

kannon92
kannon92 reviewed May 20, 2025
View reviewed changes
keps/sig-node/5307-container-restart-policy/README.md
The container restart will still follow the exponential backoff to avoid
excessive resource consumption due to restarts.

## Design Details
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this interact with PodFailurePolicy?

kannon92
kannon92 reviewed May 20, 2025
View reviewed changes
keps/sig-node/5307-container-restart-policy/README.md Outdated
A clearer definition of pod restart status should be delegated to the kubelet
from the controllers. This proposal is also designed to address the gap in
Job `podRestartPolicy`. Currently `podRestartPolicy` only supported
`restartPolicy=Never`, and container in-place restarat will not be considered
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`restartPolicy=Never`, and container in-place restarat will not be considered
`restartPolicy=Never`, and container in-place restart will not be considered

@yuanwang04 yuanwang04 force-pushed the container-restart-policy branch 2 times, most recently from 81abd1c to 31eeb57 Compare May 20, 2025 22:51
@yuanwang04 yuanwang04 force-pushed the container-restart-policy branch from 31eeb57 to dd2b1f7 Compare May 20, 2025 22:52
@k8s-ci-robot
Copy link
Contributor

@yuanwang04: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-enhancements-verify dd2b1f7 link true /test pull-enhancements-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannon92 kannon92 kannon92 left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yuanwang04 @k8s-ci-robot @kannon92 @SergeyKanzhelev