Skip to content

Commit fda49d0

Browse files
authored
Merge pull request #3303 from ravisantoshgudimetla/promote-PodOS-GA
KEP-2802: Promote PodOS field to GA
2 parents 6f0d395 + ed3df05 commit fda49d0

File tree

3 files changed

+37
-3
lines changed

3 files changed

+37
-3
lines changed

keps/prod-readiness/sig-windows/2802.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,5 @@ alpha:
33
approver: "@deads2k"
44
beta:
55
approver: "@deads2k"
6+
stable:
7+
approver: "@deads2k"

keps/sig-windows/2802-identify-windows-pods-apiserver-admission/README.md

Lines changed: 33 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@
2020
- [Changes to Kubelet](#changes-to-kubelet)
2121
- [Potential future changes to Scheduler](#potential-future-changes-to-scheduler)
2222
- [Test Plan](#test-plan)
23+
- [Prerequisite testing updates](#prerequisite-testing-updates)
24+
- [Unit tests](#unit-tests)
25+
- [Integration tests](#integration-tests)
26+
- [e2e tests](#e2e-tests)
2327
- [Graduation Criteria](#graduation-criteria)
2428
- [Alpha](#alpha)
2529
- [Alpha -> Beta Graduation](#alpha---beta-graduation)
@@ -186,7 +190,32 @@ express scheduling constraints. During the alpha, we assume there are no schedul
186190
- Unit tests covering API server defaulting to various fields within pod with and without this feature
187191
- Unit tests covering admission plugins which validate/mutate pod spec based on this feature
188192
- Unit and E2E tests for Kubelet changes.
189-
- Updates to the `sig-windows` tagged tests to utilize to direct windows scheduling for all pods .
193+
- Updates to the `sig-windows` tagged tests to utilize to direct windows scheduling for all pods.
194+
195+
#### Prerequisite testing updates
196+
[x] I/we understand the owners of the involved components may require updates to existing tests to make this code solid enough prior to committing the changes necessary to implement this enhancement.
197+
198+
##### Unit tests
199+
200+
`k8s.io/kubernetes/pkg/apis/core/validation`: `06/03/2022` `82.1% of statements`
201+
`k8s.io/kubernetes/pkg/apis/core/validation/validation.go:2979`: `06/03/2022`: `76.2% of statements`
202+
`k8s.io/kubernetes/pkg/apis/core/validation/validation.go:3488`: `06/03/2022`: `92.0% of statements`
203+
`k8s.io/kubernetes/pkg/apis/core/validation/validation.go:3573`: `06/03/2022`: `100.0% of statements`
204+
`k8s.io/kubernetes/pkg/apis/core/validation/validation.go:3590`: `06/03/2022`: `65.3% of statements`
205+
`k8s.io/kubernetes/pkg/apis/core/validation/validation.go:6360`: `06/03/2022`: `100.0% of statements`
206+
207+
##### Integration tests
208+
209+
The pod security standard integration tests will be updated to include OS specific validations.
210+
211+
212+
##### e2e tests
213+
214+
There are e2e tests which
215+
- validate that the kubelet rejects the pod which have os field not matching the underlying OS
216+
- validate that the kubelet reconciles and corrects if the node's OS label is changed
217+
218+
190219
### Graduation Criteria
191220

192221
#### Alpha
@@ -201,6 +230,8 @@ express scheduling constraints. During the alpha, we assume there are no schedul
201230

202231
#### Beta -> GA Graduation
203232
- 2 examples of end users using this field
233+
- The latest version of OpenShift is using OS field in pod spec to identify pod OS and apply SCCs judiciously
234+
- Rancher, CAPZ plan to use this field.
204235

205236
### Upgrade / Downgrade Strategy
206237

@@ -380,6 +411,7 @@ Disabling the `IdentifyPodOS` featuregate will help in determining the problem.
380411
- 2021-09-08: Initial KEP merged
381412
- 2021-10-29: Initial implementation PR merged
382413
- 2022-01-19: Graduate the feature to Beta proposed
414+
- 2022-05-09: Graduate the feature to GA proposed
383415

384416

385417
## Drawbacks

keps/sig-windows/2802-identify-windows-pods-apiserver-admission/kep.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ prr-approvers:
1818
- "@deads2k"
1919
creation-date: 2021-06-28
2020
# The target maturity stage in the current dev cycle for this KEP.
21-
stage: beta
21+
stage: stable
2222

2323
# The most recent milestone for which work toward delivery of this KEP has been
2424
# done. This can be the current (upcoming) milestone, if it is being actively
2525
# worked on.
26-
latest-milestone: "v1.24"
26+
latest-milestone: "v1.25"
2727

2828
# The milestone at which this feature was, or is targeted to be, at each stage.
2929
milestone:

0 commit comments

Comments
 (0)