Merge pull request #3307 from ravisantoshgudimetla/promote-maxSurge-stable

KEP-1591: Promote DS maxSurge to GA

Author: k8s-ci-robot

keps/prod-readiness/sig-apps/1591.yaml

@@ -3,3 +3,5 @@ alpha:
   approver: "@deads2k"
 beta:
   approver: "@ehashman"
+stable:
+  approver: "@wojtek-t"

keps/sig-apps/1591-daemonset-surge/README.md

@@ -13,6 +13,10 @@
 - [Design Details](#design-details)
   - [Implications to drain](#implications-to-drain)
   - [Test Plan](#test-plan)
+    - [Prerequisite testing updates](#prerequisite-testing-updates)
+      - [Unit tests](#unit-tests)
+      - [Integration tests](#integration-tests)
+      - [e2e tests](#e2e-tests)
   - [Graduation Criteria](#graduation-criteria)
 - [Production Readiness Review Questionnaire](#production-readiness-review-questionnaire)
   - [Feature Enablement and Rollback](#feature-enablement-and-rollback)
@@ -141,6 +145,30 @@ pod). If the old pod delays deletion, then the new pod has a chance to accept ha
   * Testing should set up conflicting rules like HostPort and verify that surge fails and the correct daemonset condition is set and events are generated.
 	* A test should cover a pod going unready during rollout and verifying it is immediately replaced.
 
+
+#### Prerequisite testing updates
+[x] I/we understand the owners of the involved components may require updates to existing tests to make this code solid enough prior to committing the changes necessary to implement this enhancement.
+
+##### Unit tests
+
+```
+`k8s.io/kubernetes/pkg/apis/apps/validation`                     `06/06/2022`:     `90.6% of statements` `The tests added for the current feature in this package touches the daemonSet Spec field. No new tests are needed for promotion to GA`
+`k8s.io/kubernetes/pkg/apis/apps/validation/validation.go:387`:	 `06/06/2022`:		`100.0% of statements`
+`k8s.io/kubernetes/pkg/controller/daemon`: `06/06/2022`: `70.7% of statements`    `The tests added for the current feature in this package touches the daemonSet update strategies. No new tests are needed for promotion to GA`
+`k8s.io/kubernetes/pkg/registry/apps/daemonset`: `06/06/2022`: `31.1% of statements`  `The tests added for the current feature in this package makes sure that the kubernetes version upgrades/downgrades won't have any impact on the new field to the daemonSet api when persisting to etcd. No new tests are needed for promotion to GA`
+`k8s.io/kubernetes/pkg/registry/apps/daemonset/strategy.go:129`:	`06/06/2022`:	`100.0% of statements`
+```
+##### Integration tests
+
+A new integration which exercises maxSurge when `RollingUpdate` is used as update strategy will be added to [DS integration test suite](https://github.com/kubernetes/kubernetes/blob/master/test/integration/daemonset/daemonset_test.go)
+
+##### e2e tests
+
+An e2e test which exercises maxSurge when `RollingUpdate` is used as update strategy is added for daemonsets.
+
+- should surge pods onto nodes when spec was updated and update strategy is RollingUpdate: [test grid](https://storage.googleapis.com/k8s-triage/index.html?test=should%20surge%20pods)
+
+
 ### Graduation Criteria
 
 This will be added as a alpha field enhancement to DaemonSets with a backward compatible default. After sufficient exposure this field would be promoted to beta, and then to GA in successive releases. The feature gate for this field will be `DaemonSetUpdateSurge`.
@@ -224,7 +252,7 @@ _This section must be completed when targeting beta graduation to a release._
 
 * **Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?**
   Manually tested. No issues were found when we enabled the feature gate -> disabled it ->
-  re-enabled the feature gate. We still need to test upgrade -> downgrade -> upgrade scenario.
+  re-enabled the feature gate. Upgrade -> downgrade -> upgrade scenario was tested manually.
 
 * **Is the rollout accompanied by any deprecations and/or removals of features, APIs,
 fields of API types, flags, etc.?**
@@ -345,4 +373,5 @@ This feature will not work if the API server or etcd is unavailable as the contr
 
 - 2021-02-09: Initial KEP merged
 - 2021-03-05: Initial implementation merged
-- 2021-04-30: Graduate the feature to Beta proposed
+- 2021-04-30: Graduate the feature to Beta proposed
+- 2022-05-10: Graduate the feature to stable proposed

keps/sig-apps/1591-daemonset-surge/kep.yaml

@@ -17,9 +17,10 @@ approvers:
 prr-approvers:
   - "@deads2k"
   - "@ehashman"
+  - "@wojtek-t"
 editor: TBD
 creation-date: 2020-03-02
-last-updated: 2020-05-06
+last-updated: 2022-05-10
 status: implementable
 replaces:
 superseded-by:
@@ -34,4 +35,4 @@ latest-milestone: "v1.22"
 milestone:
   alpha: "v1.21"
   beta: "v1.22"
-  stable: "v1.24"
+  stable: "v1.25"