-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade website to Docsy 0.5.1 #531
Open
SayakMukhopadhyay
wants to merge
17
commits into
kubernetes:master
Choose a base branch
from
SayakMukhopadhyay:upgrade
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
06c84c8
Upgrade docsy to 0.1.0
SayakMukhopadhyay 502e75e
Upgrade docsy to 0.2.0
SayakMukhopadhyay f3700f6
Upgrade docsy to 0.3.0
SayakMukhopadhyay de760a7
Upgrade docsy to 0.4.0
SayakMukhopadhyay ad8c1db
Upgrade docsy to 0.5.1
SayakMukhopadhyay 381862d
fix: license info in package.json
SayakMukhopadhyay 6517167
feat: add docsy dependency installations as a dependency of build tar…
SayakMukhopadhyay 28ef958
ci: force to use a compatible node version
SayakMukhopadhyay 42b9580
Use docsy recommended way of overriding SCSS variables instead of cop…
SayakMukhopadhyay 60a420c
feat: migrate docsy from using as a submodule to an npm module
SayakMukhopadhyay 472dff6
feat: rework Makefile and Dockerfile to exclude git submodule operations
SayakMukhopadhyay 6f0fe7d
feat: remove unnecessary .gitmodules file
SayakMukhopadhyay 7ad66f9
feat: add `npm ci` as a dependant command for local execution
SayakMukhopadhyay 67237af
fix: make sure that the package files are copied before installing th…
SayakMukhopadhyay 18f03d8
chore: remove taxonomyTerm as a disabled Kind as its deprecated and r…
SayakMukhopadhyay aa529bb
fix: only mount folders that are needed so as to not shadow `node_mod…
SayakMukhopadhyay 8daa6b9
fix: run the containers without the user flag to ensure it runs as th…
SayakMukhopadhyay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
$primary: #326ce5; | ||
SayakMukhopadhyay marked this conversation as resolved.
Show resolved
Hide resolved
|
||
$secondary: #303030; | ||
SayakMukhopadhyay marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will create
/src/node_modules
, but when the repository is mounted over that, the node modules will be shadowed / hidden.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welp....that's right. Maybe I should move the
npm ci
intohack/gen-content.sh
.Seems like k8s/website too has this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, in the website,
npm ci
is in theDockerfile
(see https://github.com/kubernetes/website/blob/30350f69b1b1f258a4534be4e16f966a641b4f35/Dockerfile#L44). The way this works is that in theMakefile
, each directory is mounted explicitly (see https://github.com/kubernetes/website/blob/main/Makefile#L16) and the whole directory isn't mounted as a whole.So, we have 2 ways to work this.
npm ci
from theDockerfile
and put it in theMakefile
as(note the
npm ci && \
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do that. Otherwise,
npm
is still running in the host context, and the trust base for our [static site generation website preview] code becomes much larger.