-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cinder-csi-plugin] implement structured logging #2652
base: master
Are you sure you want to change the base?
Conversation
Hi @sergelogvinov. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
485fd9c
to
4ea910a
Compare
/ok-to-test |
@sergelogvinov thanks for the PR. Please add more context in the PR description, e.g. how logs will look like comparing to old style. Also its worth to add this link for the context https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/1602-structured-logging/README.md#new-klog-methods |
4ea910a
to
20ca44e
Compare
20ca44e
to
2ebe59e
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ab6b90e
to
874790c
Compare
874790c
to
fd2421e
Compare
/retest |
@kayrus Whenever you have a moment, could you please take a look at this? |
What this PR does / why we need it:
implement structured logging KEP 1602
CSI plugins often use common values like node name, volume name, volume ID, and instance ID in unstructured error and log messages. This makes it hard to group and sort them. I want to change these logs to structured logs, as the core Kubernetes team has decided to move in this direction
Current logs:
Structured logs
Default log keys:
func
- name of function, exampleCreateVolume
size
- volume sizevolume
- volume namevolumeID
- volume IDsnapshotID
- snapshot IDinstanceID
- instance IDzone
- availability zonecloud
- cloud configWhich issue this PR fixes(if applicable):
make sense after #2640
Special notes for reviewers:
Release note: