Skip to content

adding env variable EnableLabelPrediction #8324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 21, 2025
Merged

adding env variable EnableLabelPrediction #8324

merged 5 commits into from
Jul 21, 2025

Conversation

MaximilianoUribe
Copy link
Contributor

@MaximilianoUribe MaximilianoUribe commented Jul 14, 2025 •
edited
Loading

What type of PR is this?

/kind bug /kind flake

What this PR does / why we need it:

Added a new environment variable for label prediction, allowing self-hosted users to operate without relying entirely on input labels.

Which issue(s) this PR fixes:

Conflicts labeling upstream.

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Adding this label modifies the behavior of scaling from zero nodes. By default, this functionality is enabled, but it can be overridden if needed—primarily to avoid conflicts with existing AKS labels. To use label prediction instead of relying solely on input labels, self-hosted users can configure the EnableLabelPredictionsOnTemplate setting, which remains the recommended approach.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/flake Categorizes issue or PR as related to a flaky test. labels Jul 14, 2025
@k8s-ci-robot
Copy link
Contributor

@MaximilianoUribe: The label(s) kind//kind cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind bug /kind flake

What this PR does / why we need it:

Added a new environment variable for label prediction, allowing self-hosted users to operate without relying entirely on input labels.

Which issue(s) this PR fixes:

Conflicts labeling upstream.

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area labels Jul 14, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @MaximilianoUribe. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/cluster-autoscaler area/provider/azure Issues or PRs related to azure provider size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-area labels Jul 14, 2025
comtalyst
comtalyst reviewed Jul 14, 2025
View reviewed changes
Copy link
Contributor

@comtalyst comtalyst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good. Also consider:

  • Adding/extending unit tests? (try Copilot)
  • Try running existing E2Es if not already
  • Add a release note, given that this is a change in behavior (e.g., it is default to false, thus will remove the ability unless changed)

@comtalyst
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 14, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 14, 2025
@MaximilianoUribe
Copy link
Contributor Author

Overall looking good. Also consider:

  • Adding/extending unit tests? (try Copilot)
  • Try running existing E2Es if not already
  • Add a release note, given that this is a change in behavior (e.g., it is default to false, thus will remove the ability unless changed)

Addressed comments.

comtalyst
comtalyst reviewed Jul 14, 2025
View reviewed changes
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 15, 2025
@comtalyst
Copy link
Contributor

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2025
@comtalyst
Copy link
Contributor

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 15, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2025
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2025
@comtalyst
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: comtalyst, MaximilianoUribe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MaximilianoUribe
Copy link
Contributor Author

/cherry-pick cluster-autoscaler-release-1.30

@k8s-infra-cherrypick-robot
Copy link

@MaximilianoUribe: only kubernetes org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherry-pick cluster-autoscaler-release-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@comtalyst
Copy link
Contributor

/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.31
/cherry-pick cluster-autoscaler-release-1.32
/unhold

@k8s-infra-cherrypick-robot
Copy link

@comtalyst: once the present PR merges, I will cherry-pick it on top of cluster-autoscaler-release-1.30, cluster-autoscaler-release-1.31, cluster-autoscaler-release-1.32 in new PRs and assign them to you.

In response to this:

/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.31
/cherry-pick cluster-autoscaler-release-1.32
/unhold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit f9b93ec into kubernetes:master Jul 21, 2025
8 checks passed
@k8s-infra-cherrypick-robot
Copy link

@comtalyst: new pull request created: #8338

In response to this:

/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.31
/cherry-pick cluster-autoscaler-release-1.32
/unhold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 21, 2025
Merged
@k8s-infra-cherrypick-robot
Copy link

@comtalyst: new pull request created: #8339

In response to this:

/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.31
/cherry-pick cluster-autoscaler-release-1.32
/unhold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 21, 2025
Merged
@k8s-infra-cherrypick-robot
Copy link

@comtalyst: new pull request created: #8340

In response to this:

/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.31
/cherry-pick cluster-autoscaler-release-1.32
/unhold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 21, 2025
Merged
@MaximilianoUribe MaximilianoUribe deleted the muribefalcon/labelprediction branch July 21, 2025 17:11
@comtalyst
Copy link
Contributor

/cherry-pick cluster-autoscaler-release-1.33

@k8s-infra-cherrypick-robot
Copy link

@comtalyst: new pull request created: #8343

In response to this:

/cherry-pick cluster-autoscaler-release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 21, 2025
Merged
kamarabbas99 pushed a commit to kamarabbas99/autoscaler that referenced this pull request Jul 29, 2025
@MaximilianoUribe @kamarabbas99
adding env variable EnableLabelPrediction (kubernetes#8324)
07e4a8f 
* adding env variable EnableLabelPrediction

* addressing comments

* adding ut test and nil scenario

* adding ephemeral storage ut

* changing default value to true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comtalyst comtalyst comtalyst approved these changes

@feiskyer feiskyer Awaiting requested review from feiskyer

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@comtalyst comtalyst

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaximilianoUribe @k8s-ci-robot @comtalyst @k8s-infra-cherrypick-robot