-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document VPA behavior for sidecar containers and how to change it #7645
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Omer Aplatony <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: omerap12 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -0,0 +1,173 @@ | |||
# VPA Sidecar Container Management | |||
|
|||
The Vertical Pod Autoscaler (VPA) has specific behavior when dealing with sidecar containers that are injected into pods via admission webhooks. This document explains the default behavior and how to customize it for your needs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does "Sidecar" refer to "A container that isn't the main one", or to the formal Sidecar definition (ie: https://kubernetes.io/docs/concepts/workloads/pods/sidecar-containers/)
I assume it's the former. It may be good to clarity this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in 3e4addd
Co-authored-by: Adrian Moisey <[email protected]>
Documentation is hard, so thanks for doing this. I'm wondering how this page fits into the broader layout of the documents. My best guess is that it's a "FAQ" (ie: https://github.com/kubernetes/autoscaler/blob/master/vertical-pod-autoscaler/docs/faq.md). I'm not entirely sold on that though. Having the document exist is a great first step, we can move it later if needed. |
Signed-off-by: Omer Aplatony <[email protected]>
I was wondering about that as well. Perhaps @voelzmo might have some ideas on how the overall layout should be structured |
/retest |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Document VPA behavior for sidecar containers and how to change it
Which issue(s) this PR fixes:
Fixes #7641
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: