doc(gce): Update manual MIG specification URL

[whisperity]

What type of PR is this?

/kind documentation

What this PR does / why we need it:

The documentation can not be applied cleanly and results in errors, the code claims to expect …/instanceGroups/ in the URL but the documentation specifies …/instanceGroupManagers/:

I1211 11:40:11.612854       1 gce_manager.go:176] GCE projectId=foobar-... location=europe-...
F1211 11:40:11.613108       1 gce_cloud_provider.go:388] Failed to create GCE Manager:
  failed to fetch MIGs:
  failed to parse mig URL:
    https://content.googleapis.com/compute/v1/projects/foobar-.../zones/europe-.../instanceGroupManagers/kubernetes-...
  got error: wrong URL:
    expected format https://.*/projects/<project-id>/zones/<zone>/instanceGroups/<name>,
    got https://content.googleapis.com/compute/v1/projects/foobar-.../zones/europe-.../instanceGroupManagers/kubernetes-...

Which issue(s) this PR fixes:

No corresponding issue.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: whisperity (bdcb977)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: whisperity
Once this PR has been reviewed and has the lgtm label, please assign gjtempleton for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• charts/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @whisperity!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @whisperity. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Shubham82]

Hi @whisperity, Please address the failed Test Cases, i.e. Lint and Test Charts / Helm chart (pull_request) and Lint and Test Charts / Helm Docs (pull_request), which are required to be passed.

[Shubham82]

The Lint and Test Charts / Helm chart (pull_request) test case failed because no bump version was performed.
Below is the error message:

✖︎ cluster-autoscaler => (version: "9.43.2", path: "charts/cluster-autoscaler") > Chart version not ok. Needs a version bump!

So you need to bump the chart version to 9.43.3 (as per current chart version)

[Shubham82]

The Lint and Test Charts / Helm Docs (pull_request) test case failed because you directly made the changes in the README.md file, we use Pre-commit hooks to update README.md file.

So The README.md is generated by helm-docs from the README.md.gotmpl file, So if you want to make changes to the README.md file other than those in the values.yaml file, you need to make changes in the README.md.gotmpl file.

[whisperity]

The Lint and Test Charts / Helm chart (pull_request) test case failed because no bump version was performed. Below is the error message:

✖︎ cluster-autoscaler => (version: "9.43.2", path: "charts/cluster-autoscaler") > Chart version not ok. Needs a version bump!

So you need to bump the chart version to 9.43.3 (as per current chart version)

This looks like a false positive, because I am only touching the documentation. Or is the README.md also versioned? They usually are not part of the "distribution", this is the first time I am encountering such an issue.

So The README.md is generated by helm-docs from the README.md.gotmpl file, So if you want to make changes to the README.md file other than those in the values.yaml file, you need to make changes in the README.md.gotmpl file.

Will do this tomorrow!

[Shubham82]

This looks like a false positive, because I am only touching the documentation. Or is the README.md also versioned? They usually are not part of the "distribution", this is the first time I am encountering such an issue.

@whisperity, we have to update the helm charts version whenever we make changes in the Charts.
Also, we use automated tooling to build and publish the releases of the helm chart, here is the workflow link:

https://github.com/kubernetes/autoscaler/blob/master/.github/workflows/release.yaml#L4-L29

[Shubham82]

@jackfrancis, can we add this PR to the Dashboard that you created for tracking helm chart PR, so we can avoid merge conflict errors (due to chart version) on this PR?

putting this PR on hold till then.

/hold

[Shubham82]

/ok-to-test

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.