-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): custom arguments #7423
Conversation
Welcome @nicolas-laduguie! |
Hi @nicolas-laduguie. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@gjtempleton @jackfrancis this PR is ready for review 👍 |
7d46122
to
b7c4bb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
to @gjtempleton for approval
There are more than one helm chart updates in flight so depending on which lands first you may need a rebase and I'll re-apply lgtm
FYI!
/assign @gjtempleton |
/ok-to-test |
Hello team, what is the next step for this PR to be merged ? |
0efce5f
to
6e8a548
Compare
Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gjtempleton, jackfrancis, nicolas-laduguie The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add custom arguments feature to helm chart.
Which issue(s) this PR fixes:
Fixes #7422
Special notes for your reviewer:
Does this PR introduce a user-facing change?