Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support applying tolerations to cleanup jobs #456

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

twelho
Copy link
Contributor

@twelho twelho commented Aug 31, 2024

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind test
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:

At the moment, if the DaemonSet is deployed with tolerations, and useJobForCleaning: true, those tolerations do not get transferred to deployed Jobs. If, for example, the DaemonSet tolerates running on control plane nodes, the cleanup jobs it deploys targeting those nodes will never get scheduled due to lack of toleration. By adding a tolerations field to the config, the Helm chart can automatically populate it based on .Values.tolerations. Now all deployed jobs should inherit the same tolerations as the parent DaemonSet.

Which issue(s) this PR fixes:

Fixes #253

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 31, 2024
Copy link

linux-foundation-easycla bot commented Aug 31, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: twelho / name: Dennis Marttinen (41a81b1)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 31, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @twelho!

It looks like this is your first PR to kubernetes-sigs/sig-storage-local-static-provisioner 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/sig-storage-local-static-provisioner has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 31, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @twelho. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 31, 2024
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 1, 2024
At the moment, if the DaemonSet is deployed with tolerations, and `useJobForCleaning: true`, those tolerations do not get transferred to deployed Jobs. If, for example, the DaemonSet tolerates running on control plane nodes, the cleanup jobs it deploys targeting those nodes will never get scheduled due to lack of toleration. By adding a tolerations field to the config, the Helm chart can automatically populate it based on `.Values.tolerations`. Now all deployed jobs should inherit the same tolerations as the parent DaemonSet.
@twelho
Copy link
Contributor Author

twelho commented Sep 2, 2024

Re-generated the examples with hack/update-generated.sh, should pass the test now.

Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, twelho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2024
@andyzhangx andyzhangx merged commit 8226e7a into kubernetes-sigs:master Sep 14, 2024
12 of 13 checks passed
@twelho twelho deleted the job-tolerations branch September 16, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup Job doesn't have the same tolerations as the daemonset
3 participants