Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hostPID for linux daemonset container #449

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions helm/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ provisioner chart and their default values.
| classes.[n].storageClass.provisioner | Specify provisioner of storage class. | str | `kubernetes.io/no-provisioner` |
| podAnnotations | Annotations for each Pod in the DaemonSet. | map | `-` |
| podLabels | Labels for each Pod in the DaemonSet. | map | `-` |
| hostPID | Host PID set in the linux daemonset container spec. When set to true allows a pod to have access to the host process ID namespace | bool | `false` |
| image | Provisioner image. | str | `registry.k8s.io/sig-storage/local-volume-provisioner:v2.7.0` |
| imagePullPolicy | Provisioner DaemonSet image pull policy. | str | `-` |
| imagePullSecrets | Provisioner image pull secrets. | list | `-` |
Expand Down
1 change: 1 addition & 0 deletions helm/generated_examples/additional-volumes.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ spec:
annotations:
checksum/config: 997271ac2c9e49ae617e255f4d6e709709aa662e1049fef537e81f1b4d6b36a9
spec:
hostPID: false
serviceAccountName: local-static-provisioner
nodeSelector:
kubernetes.io/os: linux
Expand Down
1 change: 1 addition & 0 deletions helm/generated_examples/baremetal-affinity.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ spec:
annotations:
checksum/config: f81e575a8ce66fff1873e5bae2df0f963609f540da196b9a86c3146a94d284b8
spec:
hostPID: false
serviceAccountName: local-static-provisioner
nodeSelector:
kubernetes.io/os: linux
Expand Down
1 change: 1 addition & 0 deletions helm/generated_examples/baremetal-cleanbyjobs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ spec:
annotations:
checksum/config: b83faf15a16c9079bcd422cd130bbeef24dd946545b9e66f70eb6cfe7fd2036f
spec:
hostPID: false
serviceAccountName: local-static-provisioner
nodeSelector:
kubernetes.io/os: linux
Expand Down
1 change: 1 addition & 0 deletions helm/generated_examples/baremetal-default-storage.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ spec:
annotations:
checksum/config: b6d9b5373d0044b95f32c0a7bca03c3bfd69cab1e45ad38029cda321ff703452
spec:
hostPID: false
serviceAccountName: local-static-provisioner
nodeSelector:
kubernetes.io/os: linux
Expand Down
1 change: 1 addition & 0 deletions helm/generated_examples/baremetal-nodeselector.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ spec:
annotations:
checksum/config: f81e575a8ce66fff1873e5bae2df0f963609f540da196b9a86c3146a94d284b8
spec:
hostPID: false
serviceAccountName: local-static-provisioner
nodeSelector:
kubernetes.io/os: linux
Expand Down
1 change: 1 addition & 0 deletions helm/generated_examples/baremetal-priority-critical.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ spec:
annotations:
checksum/config: f81e575a8ce66fff1873e5bae2df0f963609f540da196b9a86c3146a94d284b8
spec:
hostPID: false
serviceAccountName: local-static-provisioner
priorityClassName: system-node-critical
nodeSelector:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ spec:
annotations:
checksum/config: f81e575a8ce66fff1873e5bae2df0f963609f540da196b9a86c3146a94d284b8
spec:
hostPID: false
serviceAccountName: local-static-provisioner
priorityClassName: priority-important
nodeSelector:
Expand Down
1 change: 1 addition & 0 deletions helm/generated_examples/baremetal-prometheus.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ spec:
annotations:
checksum/config: f81e575a8ce66fff1873e5bae2df0f963609f540da196b9a86c3146a94d284b8
spec:
hostPID: false
serviceAccountName: local-static-provisioner
nodeSelector:
kubernetes.io/os: linux
Expand Down
1 change: 1 addition & 0 deletions helm/generated_examples/baremetal-provisioner.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ spec:
annotations:
checksum/config: ab47134c2d9ee94cf8fc7f8a5a8dc9e51c2ab005a6ce67ff013328751015dec8
spec:
hostPID: false
serviceAccountName: local-static-provisioner
nodeSelector:
kubernetes.io/os: linux
Expand Down
1 change: 1 addition & 0 deletions helm/generated_examples/baremetal-resyncperiod.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ spec:
annotations:
checksum/config: 411fa024d9706715e0bb5b76a4549e8a4593abf40e873bc49aaea223649af713
spec:
hostPID: false
serviceAccountName: local-static-provisioner
nodeSelector:
kubernetes.io/os: linux
Expand Down
1 change: 1 addition & 0 deletions helm/generated_examples/baremetal-tolerations.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ spec:
annotations:
checksum/config: bdea962be4bc6072011b44367cc56d21c61868009d4cb63b6415c1c27695ce96
spec:
hostPID: false
serviceAccountName: local-static-provisioner
nodeSelector:
kubernetes.io/os: linux
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ spec:
annotations:
checksum/config: f81e575a8ce66fff1873e5bae2df0f963609f540da196b9a86c3146a94d284b8
spec:
hostPID: false
serviceAccountName: local-static-provisioner
nodeSelector:
kubernetes.io/os: linux
Expand Down
1 change: 1 addition & 0 deletions helm/generated_examples/baremetal-without-rbac.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ spec:
annotations:
checksum/config: ab47134c2d9ee94cf8fc7f8a5a8dc9e51c2ab005a6ce67ff013328751015dec8
spec:
hostPID: false
serviceAccountName: local-static-provisioner
nodeSelector:
kubernetes.io/os: linux
Expand Down
1 change: 1 addition & 0 deletions helm/generated_examples/baremetal.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ spec:
annotations:
checksum/config: f81e575a8ce66fff1873e5bae2df0f963609f540da196b9a86c3146a94d284b8
spec:
hostPID: false
serviceAccountName: local-static-provisioner
nodeSelector:
kubernetes.io/os: linux
Expand Down
1 change: 1 addition & 0 deletions helm/generated_examples/development-gce.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ spec:
annotations:
checksum/config: 3ac145a21b1cd813079bd65a84010c8c39cb1513e676cf78e78f236461c6ae7e
spec:
hostPID: false
serviceAccountName: local-static-provisioner
nodeSelector:
kubernetes.io/os: linux
Expand Down
1 change: 1 addition & 0 deletions helm/generated_examples/development-gke.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ spec:
annotations:
checksum/config: 3ac145a21b1cd813079bd65a84010c8c39cb1513e676cf78e78f236461c6ae7e
spec:
hostPID: false
serviceAccountName: local-static-provisioner
nodeSelector:
kubernetes.io/os: linux
Expand Down
1 change: 1 addition & 0 deletions helm/generated_examples/eks-nvme-ssd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ spec:
annotations:
checksum/config: b110cd9aea997eefa707c673fe5efa712280f77f1e5af3ff591359246cba3d9e
spec:
hostPID: false
serviceAccountName: local-static-provisioner
nodeSelector:
kubernetes.io/os: linux
Expand Down
1 change: 1 addition & 0 deletions helm/generated_examples/gce-retain.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ spec:
annotations:
checksum/config: fc2f7f8aebef1f9b2f9727f6502b2a98fb7e6739e66c162a356b3e086fa6ce70
spec:
hostPID: false
serviceAccountName: local-static-provisioner
nodeSelector:
kubernetes.io/os: linux
Expand Down
1 change: 1 addition & 0 deletions helm/generated_examples/gce.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ spec:
annotations:
checksum/config: fc2f7f8aebef1f9b2f9727f6502b2a98fb7e6739e66c162a356b3e086fa6ce70
spec:
hostPID: false
serviceAccountName: local-static-provisioner
nodeSelector:
kubernetes.io/os: linux
Expand Down
1 change: 1 addition & 0 deletions helm/generated_examples/gke-nvme-ssd-block-raid.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ spec:
annotations:
checksum/config: d1ecfaa3b97cbc85da26d0c83192913ede08a624d630854de99db95c1a78a8bc
spec:
hostPID: false
serviceAccountName: local-static-provisioner
nodeSelector:
kubernetes.io/os: linux
Expand Down
1 change: 1 addition & 0 deletions helm/generated_examples/gke.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ spec:
annotations:
checksum/config: 3ac145a21b1cd813079bd65a84010c8c39cb1513e676cf78e78f236461c6ae7e
spec:
hostPID: false
serviceAccountName: local-static-provisioner
nodeSelector:
kubernetes.io/os: linux
Expand Down
1 change: 1 addition & 0 deletions helm/provisioner/templates/daemonset_linux.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ spec:
{{ .Values.podAnnotations | toYaml | trim | indent 8 }}
{{- end }}
spec:
hostPID: {{.Values.hostPID}}
serviceAccountName: {{ template "provisioner.serviceAccountName" . }}
{{- if .Values.priorityClassName }}
priorityClassName: {{.Values.priorityClassName}}
Expand Down
3 changes: 3 additions & 0 deletions helm/provisioner/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,9 @@ resources:
# If set to false, containers created by the Provisioner Daemonset will run without extra privileges.
privileged: true

# Host PID set in the linux daemonset container spec. When set to true allows a pod to have access to the host process ID namespace
hostPID: false

# Any init containers can be configured here.
# Ref: https://kubernetes.io/docs/concepts/workloads/pods/init-containers/
initContainers: []
Expand Down
Loading