MULTIARCH-4654: Enabled the Security Profiles Operator for ppc64le #2589

pranitaT · 2024-12-02T07:02:38Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR enables the Security Profiles Operator for the ppc64le architecture, providing support for managing seccomp and SELinux profiles. The changes have been tested and verified using logenricher to ensure functionality and compliance.

Which issue(s) this PR fixes: https://issues.redhat.com/browse/MULTIARCH-4654

Does this PR have test?

N/A

Special notes for your reviewer:

Tested for compatibility with seccomp and SELinux profiles on the ppc64le architecture.
Verified functionality using logenricher.

Does this PR introduce a user-facing change?

Enabled the Security Profiles Operator for `ppc64le` architecture with support for seccomp and SELinux profile management.

linux-foundation-easycla · 2024-12-02T07:02:42Z

The committers listed above are authorized under a signed CLA.

✅ login: pranitaT / name: Pranita Turrey (a342d35)

k8s-ci-robot · 2024-12-02T07:02:47Z

Welcome @pranitaT!

It looks like this is your first PR to kubernetes-sigs/security-profiles-operator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/security-profiles-operator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2024-12-02T07:02:48Z

Hi @pranitaT. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

saschagrunert · 2024-12-02T07:57:23Z

Thank you for the PR @pranitaT, do you mind signing the CLA?

prb112 · 2024-12-02T18:57:27Z

Hey @saschagrunert I shared with Pranita how our team signs the CLA. We'll get this done a.s.a.p. Thank you for the time, Paul

prb112 · 2024-12-02T19:02:44Z

deploy/base/clusterserviceversion.yaml

+    operatorframework.io/arch.amd64: supported
+    operatorframework.io/arch.ppc64le: supported


Suggested change

operatorframework.io/arch.amd64: supported

operatorframework.io/arch.ppc64le: supported

We don't need the arches. I think arm/amd64 are already supported and we are adding s390x.

prb112 · 2024-12-02T19:05:16Z

internal/pkg/daemon/bpfrecorder/generate/main.go

@@ -102,7 +102,7 @@ func generateBpfObj(builder *strings.Builder) error {
 	builder.WriteString(header)
 	builder.WriteString("var bpfObjects = map[string][]byte{\n")

-	for _, arch := range []string{"amd64", "arm64"} {
+	for _, arch := range []string{"amd64", "arm64", "ppc64le", "s390x"} {


Suggested change

for _, arch := range []string{"amd64", "arm64", "ppc64le", "s390x"} {

for _, arch := range []string{"amd64", "arm64"} {

sorry based on testing, I don't think we need this anymore.

prb112 · 2024-12-02T19:05:55Z

internal/pkg/daemon/bpfrecorder/generate/main.go

@@ -65,7 +65,7 @@ const (
 	docsHeader  = "The following Kernels are supported to run the BPF recorder " +
 		"beside those which already expose `/sys/kernel/btf/vmlinux`. " +
 		"Please note that at least a Linux kernel version 5.8 is required " +
-		"to use the bpf recorder.\n\n"
+		"to use the bpf recorder, and this includes support for ppc64le and s390x architectures.\n\n"


Suggested change

"to use the bpf recorder, and this includes support for ppc64le and s390x architectures.\n\n"

"to use the bpf recorder.\n\n"

saschagrunert · 2024-12-03T09:23:46Z

Please rebase to fix the CI

saschagrunert · 2024-12-04T07:58:02Z

/ok-to-test

prb112 · 2024-12-04T17:16:17Z

internal/pkg/daemon/bpfrecorder/bpfrecorder_stub.go

@@ -0,0 +1,16 @@
+//go:build !ppc64le && !s390x
+// +build !ppc64le,!s390x


Suggested change

// +build !ppc64le,!s390x

// +build !ppc64le,!s390x,!amd64

Or remove the amd64 entry, and push the method details in here.

Probably need to change to _default.go or something along those lines

k8s-ci-robot · 2025-01-07T11:41:52Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pranitaT
Once this PR has been reviewed and has the lgtm label, please assign jaormx for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

prb112 · 2025-01-07T13:47:52Z

bundle/manifests/security-profiles-operator-profile_v1_configmap.yaml

-        "SCMP_ARCH_AARCH64"
+        "SCMP_ARCH_AARCH64",
+        "SCMP_ARCH_PPC64LE",
+        "SCMP_ARCH_PPC"


probably need to update configmap with archMap here...

…dded fixes for seccomp and SELinux profiles, and verified functionality with logenricher. Signed-off-by: Pranita Turrey <[email protected]>

k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 2, 2024

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 2, 2024

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 2, 2024

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 2, 2024

k8s-ci-robot requested review from saschagrunert and Vincent056 December 2, 2024 07:02

prb112 reviewed Dec 2, 2024

View reviewed changes

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 4, 2024

pranitaT force-pushed the nov24-ppc64le-support branch 3 times, most recently from 57bc010 to afbcb5b Compare December 4, 2024 06:40

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 4, 2024

prb112 reviewed Dec 4, 2024

View reviewed changes

pranitaT force-pushed the nov24-ppc64le-support branch 5 times, most recently from f889b64 to 98c7a11 Compare December 5, 2024 12:13

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 7, 2025

prb112 reviewed Jan 7, 2025

View reviewed changes

pranitaT force-pushed the nov24-ppc64le-support branch 4 times, most recently from d141c9d to 0589431 Compare January 13, 2025 10:56

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/contains-merge-commits and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 13, 2025

pranitaT force-pushed the nov24-ppc64le-support branch from 4bfafdb to 1582e6b Compare January 14, 2025 07:32

k8s-ci-robot removed the do-not-merge/contains-merge-commits label Jan 14, 2025

pranitaT force-pushed the nov24-ppc64le-support branch 8 times, most recently from 6a5b0cc to ed62724 Compare January 15, 2025 13:00

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 15, 2025

pranitaT force-pushed the nov24-ppc64le-support branch from ed62724 to ec58ac1 Compare January 15, 2025 13:10

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 15, 2025

pranitaT force-pushed the nov24-ppc64le-support branch 2 times, most recently from 3768c94 to 1572e7c Compare January 15, 2025 14:41

MULTIARCH-4654: Enabled the Security Profiles Operator for ppc64le, a…

a342d35

…dded fixes for seccomp and SELinux profiles, and verified functionality with logenricher. Signed-off-by: Pranita Turrey <[email protected]>

pranitaT force-pushed the nov24-ppc64le-support branch from 1572e7c to a342d35 Compare January 15, 2025 14:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MULTIARCH-4654: Enabled the Security Profiles Operator for ppc64le #2589

MULTIARCH-4654: Enabled the Security Profiles Operator for ppc64le #2589

pranitaT commented Dec 2, 2024 •

edited by saschagrunert

Loading

linux-foundation-easycla bot commented Dec 2, 2024 •

edited

Loading

k8s-ci-robot commented Dec 2, 2024

k8s-ci-robot commented Dec 2, 2024

saschagrunert commented Dec 2, 2024

prb112 commented Dec 2, 2024

prb112 Dec 2, 2024

prb112 Dec 2, 2024

prb112 Dec 2, 2024

prb112 Dec 2, 2024

saschagrunert commented Dec 3, 2024

saschagrunert commented Dec 4, 2024

prb112 Dec 4, 2024

prb112 Dec 4, 2024

k8s-ci-robot commented Jan 7, 2025

prb112 Jan 7, 2025

		operatorframework.io/arch.amd64: supported
		operatorframework.io/arch.ppc64le: supported

	for _, arch := range []string{"amd64", "arm64", "ppc64le", "s390x"} {
	for _, arch := range []string{"amd64", "arm64"} {

	"to use the bpf recorder, and this includes support for ppc64le and s390x architectures.\n\n"
	"to use the bpf recorder.\n\n"

		@@ -0,0 +1,16 @@
		//go:build !ppc64le && !s390x
		// +build !ppc64le,!s390x

MULTIARCH-4654: Enabled the Security Profiles Operator for ppc64le #2589

Are you sure you want to change the base?

MULTIARCH-4654: Enabled the Security Profiles Operator for ppc64le #2589

Conversation

pranitaT commented Dec 2, 2024 • edited by saschagrunert Loading

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes: https://issues.redhat.com/browse/MULTIARCH-4654

Does this PR have test?

Special notes for your reviewer:

Does this PR introduce a user-facing change?

linux-foundation-easycla bot commented Dec 2, 2024 • edited Loading

k8s-ci-robot commented Dec 2, 2024

k8s-ci-robot commented Dec 2, 2024

saschagrunert commented Dec 2, 2024

prb112 commented Dec 2, 2024

prb112 Dec 2, 2024

Choose a reason for hiding this comment

prb112 Dec 2, 2024

Choose a reason for hiding this comment

prb112 Dec 2, 2024

Choose a reason for hiding this comment

prb112 Dec 2, 2024

Choose a reason for hiding this comment

saschagrunert commented Dec 3, 2024

saschagrunert commented Dec 4, 2024

prb112 Dec 4, 2024

Choose a reason for hiding this comment

prb112 Dec 4, 2024

Choose a reason for hiding this comment

k8s-ci-robot commented Jan 7, 2025

prb112 Jan 7, 2025

Choose a reason for hiding this comment

pranitaT commented Dec 2, 2024 •

edited by saschagrunert

Loading

linux-foundation-easycla bot commented Dec 2, 2024 •

edited

Loading