WIP: ✨provider acceptance tests #79
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ntnn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XXL
|
cc @embik @mjudeikis @FourFifthsCode ptal |
ntnn
commented
Oct 7, 2025
pkg/acceptance/testing.go
Outdated
Comment on lines
21
to
34
| // TestingT is the minimal subset of testing.TB needed for acceptance | ||
| // tests. | ||
| type TestingT interface { | ||
| Context() context.Context | ||
| TempDir() string | ||
| Helper() | ||
| Cleanup(func()) | ||
| Log(args ...any) | ||
| Logf(format string, args ...any) | ||
| Error(args ...any) | ||
| Errorf(format string, args ...any) | ||
| Fatal(args ...any) | ||
| Fatalf(format string, args ...any) | ||
| } |
There was a problem hiding this comment.
Currently unused. I started with this but I think every testing framework should now support testing.TB.
ntnn
force-pushed
the
acceptance
branch
3 times, most recently
from
fc06501 to
e33a285
Compare
|
totally diggin this! haven't reviewed in full yet but initial pass looks really cool! |
k8s-ci-robot
added
the
needs-rebase
Signed-off-by: Nelo-T. Wallus <[email protected]> Signed-off-by: Nelo-T. Wallus <[email protected]>
k8s-ci-robot
removed
the
needs-rebase
Signed-off-by: Nelo-T. Wallus <[email protected]> Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]> Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]> Signed-off-by: Nelo-T. Wallus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
pkg/acceptance, a package providers can use to validate their functionality with as little boilerplate as possible.Implements acceptance tests for the in-tree providers
fileandclusters.The bump to ginkgo v2.22.0 is required as the current version returns nil on
ginkgo.GinktoTB().Context().