Update golangci to v2

[tylerauerbeck]

This PR moves golangci-lint to v2 by running golangci-lint migrate using the v2 cli. It also addresses the handful of lints that were picked up by the updated linters.

[k8s-ci-robot]

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tylerauerbeck
Once this PR has been reviewed and has the lgtm label, please assign knverey for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @tylerauerbeck!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @tylerauerbeck. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[stormqueen1990]

Hi there, @tylerauerbeck!

It looks like golangci-lint v2 requires Go 1.23, but I noticed that this isn't updated in .golangci.yml (it still says 1.22 there). I also see some test and lint failures in our pipelines. Could you please take a look at those?

[koba1t]

@stormqueen1990
In my opinion, If we will introduce golangci-lint v2, We need to upgrade go version for kustomize before upgrade golangci-lint like #5763.
I believe partial golang version upgrades should be avoided for future maintainability.

[koba1t]

HI @tylerauerbeck
Thanks for your contribution!

I agree to upgrade golangci-lint to v2 and I want to upgrade that.
But currently there is just a bit issue on the kustomize repo side to implement this upgrade.

[tylerauerbeck]

@koba1t That's a good point. Please see the bump to 1.24 in #5920