Helm V3 support #5385

lohmag · 2019-11-27T08:41:30Z

Patch to support helm3, it doesn't need tiller anymore so this part is obsolete.
Several commands also changed. Helm2 not backward compatible with 3 version.
#4777

k8s-ci-robot · 2019-11-27T08:41:33Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2019-11-27T08:41:37Z

Welcome @lohmag!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

lohmag · 2019-11-27T09:05:52Z

/retest

lohmag · 2019-11-27T09:06:03Z

/check-cla

k8s-ci-robot · 2019-11-27T09:06:05Z

@lohmag: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lohmag · 2019-11-27T09:08:04Z

/assign @mattymo

roles/kubernetes-apps/helm/defaults/main.yml

mirwan · 2019-11-27T18:30:35Z

roles/kubernetes-apps/helm/tasks/main.yml

-  include_tasks: "gen_helm_tiller_certs.yml"
-  when: tiller_enable_tls
-
- name: Helm | Install client on all masters


Maybe this task should not be removed but modified to simply add stable repo when helm_stable_repo_url is defined?

I can't get a point of this. If it doesn't need tiller then what for it repo in chart? I think to just delete helm_stable_repo_url in next commit

In pre-v3, helm init not only installed tiller but also initiated the helm client on members of the kube-master group (optionally including adding stable repo). That made helm directly usable to install charts from stable repo on masters for users who chose to enable helm_stable_repo_url in their inventory.
Your changes make the current behaviour change.

mirwan · 2019-11-27T18:35:45Z

/check-cla

lohmag

Removed odsolete vars

lohmag · 2019-11-28T08:22:39Z

roles/kubernetes-apps/helm/tasks/main.yml

-  include_tasks: "gen_helm_tiller_certs.yml"
-  when: tiller_enable_tls
-
- name: Helm | Install client on all masters


I can't get a point of this. If it doesn't need tiller then what for it repo in chart? I think to just delete helm_stable_repo_url in next commit

mirwan · 2019-12-02T19:37:25Z

/lgtm /approve

Miouge1 · 2019-12-04T16:33:28Z

Since Helm 3 has been released every recently, I think it's too early to include that in 2.12, therefore I mark it for 2.13.

mirwan · 2019-12-04T18:46:13Z

@Miouge1 Do you know why the PR has been merged despite my lgtm and approve? I guess it's because the PR may be based on an earlier commit of master than the one with me as approver, but your last comment made me doubt it...

Miouge1 · 2019-12-04T18:51:21Z

@mirwan the OWNERS file changes take effect immediately, I think it's because the commands have to be one per line.

I would prefer to hold this for 2.13 but it's up for discussion.

mirwan · 2019-12-04T19:06:30Z

Is there a due date for 2.12 or is it when the related issues are done, just out of curiosity? Anyway, I'm fine with it.
Does it mean I should add a comment with lgtm approve hold (one per line) ?

Miouge1 · 2019-12-05T11:51:17Z

Yep one per line.

mirwan · 2019-12-05T17:23:57Z

/lgtm
/approve

mirwan · 2019-12-05T17:24:00Z

/hold

k8s-ci-robot · 2019-12-05T17:24:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lohmag, mirwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mirwan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mirwan · 2019-12-05T17:31:14Z

@lohmag It seems that the support of helm v2 (as well as v3) would be a requirement until some other release so that users can migrate when they want.
It would mean to keep the removed tasks installing tiller, add condition on them (based on helm_version) and cleanup tiller pods when helm version is not v2.
I don't know if you're ok with handling this not, if not, that's fine I could modify the PR myself. Just let me know

lohmag · 2019-12-09T14:33:25Z

@mirwan Sounds ok except for those part where it should cleanup tiller pods when helm version is not v2. It's not that easy because it need to create secrets for helm3 from helm2 tiller and etcd configs.
I found this utility to do this job -
https://github.com/helm/helm-2to3
Maybe it should be added to kubespray somehow.. I need to think more about it.

lohmag · 2019-12-09T16:08:25Z

@mirwan I think it will be nice to add flag to config for switching beetween helm2/helm3. Helm2 will be used by default. If user has already created cluster he should migrate to helm3 by himself and switch flag.

Miouge1 · 2019-12-11T08:45:13Z

Anything I should add in the 2.12 release notes (see #5409) around Helm 2 and 3?

lohmag · 2019-12-11T15:27:47Z

@Miouge1 Not ready yet

Miouge1 · 2019-12-12T19:07:40Z

I'll copy part of the Slack discussion related to Helm v3 and how this is a bit different than #5441

maybe for 2.13, we can set helm_version to 3 by default
and for 2.14, we can remove 2 support 😉

k8s-ci-robot · 2019-12-12T19:07:48Z

@lohmag: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miouge1 · 2020-02-13T10:20:16Z

Thanks everyone involved in this PR, we just merged #5503 instead.

Nikita Massalitin added 2 commits November 26, 2019 18:39

delete tiller part

27bb240

ver bump

4541c1a

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 27, 2019

k8s-ci-robot requested review from holmsten and mattymo November 27, 2019 08:41

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 27, 2019

k8s-ci-robot assigned mattymo Nov 27, 2019

mirwan reviewed Nov 27, 2019

View reviewed changes

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 27, 2019

remove obsolete vars

9f95105

lohmag commented Nov 28, 2019

View reviewed changes

add repo step

47b3f1b

mirwan self-requested a review December 2, 2019 20:19

mirwan approved these changes Dec 2, 2019

View reviewed changes

Miouge1 added this to the 2.13 milestone Dec 4, 2019

k8s-ci-robot assigned mirwan Dec 5, 2019

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 5, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2019

Miouge1 mentioned this pull request Dec 12, 2019

Add Helm 3.x support #5441

Merged

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2019

Miouge1 closed this Feb 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Helm V3 support #5385

Helm V3 support #5385

lohmag commented Nov 27, 2019 •

edited

Loading

k8s-ci-robot commented Nov 27, 2019

k8s-ci-robot commented Nov 27, 2019

lohmag commented Nov 27, 2019

lohmag commented Nov 27, 2019

k8s-ci-robot commented Nov 27, 2019

lohmag commented Nov 27, 2019

mirwan Nov 27, 2019 •

edited

Loading

lohmag Nov 28, 2019

mirwan Nov 30, 2019

mirwan commented Nov 27, 2019

lohmag left a comment

lohmag Nov 28, 2019

mirwan commented Dec 2, 2019

Miouge1 commented Dec 4, 2019

mirwan commented Dec 4, 2019

Miouge1 commented Dec 4, 2019

mirwan commented Dec 4, 2019

Miouge1 commented Dec 5, 2019

mirwan commented Dec 5, 2019

mirwan commented Dec 5, 2019

k8s-ci-robot commented Dec 5, 2019

mirwan commented Dec 5, 2019

lohmag commented Dec 9, 2019

lohmag commented Dec 9, 2019

Miouge1 commented Dec 11, 2019

lohmag commented Dec 11, 2019

Miouge1 commented Dec 12, 2019

k8s-ci-robot commented Dec 12, 2019

Miouge1 commented Feb 13, 2020

Helm V3 support #5385

Helm V3 support #5385

Conversation

lohmag commented Nov 27, 2019 • edited Loading

k8s-ci-robot commented Nov 27, 2019

k8s-ci-robot commented Nov 27, 2019

lohmag commented Nov 27, 2019

lohmag commented Nov 27, 2019

k8s-ci-robot commented Nov 27, 2019

lohmag commented Nov 27, 2019

mirwan Nov 27, 2019 • edited Loading

Choose a reason for hiding this comment

lohmag Nov 28, 2019

Choose a reason for hiding this comment

mirwan Nov 30, 2019

Choose a reason for hiding this comment

mirwan commented Nov 27, 2019

lohmag left a comment

Choose a reason for hiding this comment

lohmag Nov 28, 2019

Choose a reason for hiding this comment

mirwan commented Dec 2, 2019

Miouge1 commented Dec 4, 2019

mirwan commented Dec 4, 2019

Miouge1 commented Dec 4, 2019

mirwan commented Dec 4, 2019

Miouge1 commented Dec 5, 2019

mirwan commented Dec 5, 2019

mirwan commented Dec 5, 2019

k8s-ci-robot commented Dec 5, 2019

mirwan commented Dec 5, 2019

lohmag commented Dec 9, 2019

lohmag commented Dec 9, 2019

Miouge1 commented Dec 11, 2019

lohmag commented Dec 11, 2019

Miouge1 commented Dec 12, 2019

k8s-ci-robot commented Dec 12, 2019

Miouge1 commented Feb 13, 2020

lohmag commented Nov 27, 2019 •

edited

Loading

mirwan Nov 27, 2019 •

edited

Loading