Skip to content

Add astl for fast local Ansible static linting - #13472

Open
arhuman wants to merge 1 commit into
kubernetes-sigs:masterfrom
arhuman:astl-precommit
Open

Add astl for fast local Ansible static linting#13472
arhuman wants to merge 1 commit into
kubernetes-sigs:masterfrom
arhuman:astl-precommit

Conversation

@arhuman

@arhuman arhuman commented Sep 5, 2026

Copy link
Copy Markdown

What type of PR is this?

/kind feature

What this PR does / why we need it:

Implements the proposal accepted in #13426: give developers fast local lint
feedback without weakening CI.

  • Adds astl (ansible-static-lint)
    as a normal pre-commit hook, pinned at v0.5.0. It covers the ansible-lint rules
    decidable from YAML source alone and produces byte-identical findings for those
    rules. On this repository it runs in ~129ms where the ansible-lint hook takes ~51s.
  • Moves the ansible-lint hook to stages: [manual]. It is not removed and not
    replaced: CI still runs the full ansible-lint via an explicit
    pre-commit run ansible-lint --hook-stage manual step added to the lint job,
    so nothing ansible-lint checks today stops being checked.

The astl hook uses language: golang, so pre-commit builds it from the pinned
tag and bootstraps the Go toolchain itself if absent (pre-commit >= 3.0). No new
prerequisite for contributors.

Which issue(s) this PR fixes:

Fixes #13426

Special notes for your reviewer:

The lint job currently fails on master with one pre-existing jinja[invalid]
violation (roles/kubernetes/client/tasks/main.yml:70, triggered by
ansible.utils 6.1.0), addressed by #13337. This PR neither causes nor fixes it;
the same single failure occurs with and without this change.

Verified locally on a clone at current HEAD:

  • pre-commit run --all-files runs astl and all other hooks, and no longer runs
    ansible-lint by default.
  • pre-commit run ansible-lint --hook-stage manual --all-files still runs the
    full ansible-lint exactly as before.

Does this PR introduce a user-facing change?

NONE

@kubernetes-prow kubernetes-prow Bot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Sep 5, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Sep 5, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: arhuman / name: Arnaud (Arhuman) ASSAD (a6c73c2)

@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arhuman
Once this PR has been reviewed and has the lgtm label, please assign yankay for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow

Copy link
Copy Markdown
Contributor

Welcome @arhuman!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 5, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @arhuman. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 5, 2026
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal: use ansible-static-lint in the pre-commit hook (396x faster, byte-identical findings)

1 participant