fix(gvisor): switch update-hashes and downloads to GitHub release tarballs - #13465
fix(gvisor): switch update-hashes and downloads to GitHub release tarballs#13465mehrdadbn9 wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mehrdadbn9 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @mehrdadbn9. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…balls
gvisor changed its release artifacts: the per-arch binary .sha512 files
under storage.googleapis.com/gvisor/releases/release/{version}/{arch}/
no longer exist for new releases, so the update-hashes script fails
with HTTP 404 and new gvisor versions cannot be added.
Since release-20260817.0, gvisor publishes GitHub releases containing
gvisor-{arch}.tar.bz2 archives plus SHA256SUMS and SHA512SUMS files.
- replace gvisor_runsc_binary and gvisor_containerd_shim_binary entries
in component_hash_update with a single gvisor_archive entry pointing
at the GitHub release SHA512SUMS file, with an extractor that maps
the two tarball hashes to x86_64/aarch64
- collapse the two download definitions (gvisor_runsc,
gvisor_containerd_shim) into one gvisor_archive download with
unarchive enabled
- copy runsc and containerd-shim-runsc-v1 from the extracted gvisor/
directory in the gvisor role
- add gvisor_archive_checksums for release-20260817.0 (amd64/arm64)
The old per-arch checksum variables remain as aliases so the checksum
data in vars/main/checksums.yml keeps resolving during the transition.
Fixes: kubernetes-sigs#13460
Signed-off-by: Mehrdad Biukian Naeini <mehrdadbiukian@gmail.com>
eb16d5d to
14a5d38
Compare
What type of PR is this?
/kind bug
What this PR does / why we need it
gVisor changed its release artifacts (
google/gvisor#13718): the per-arch binary.sha512files understorage.googleapis.com/gvisor/releases/release/{version}/{arch}/no longer exist for new releases, so theupdate-hashesscript fails with HTTP 404 and new gVisor versions cannot be added. Verified live: all.sha512URLs return 404 for20260824.0(newest tag), while20260817.0still resolves — the breakage is silent today and hard-blocks the next bump.Since
release-20260817.0, gVisor publishes GitHub releases containinggvisor-{arch}.tar.bz2archives plusSHA256SUMSandSHA512SUMSfiles.Changes:
gvisor_runsc_binary/gvisor_containerd_shim_binaryentries incomponent_hash_updatewith a singlegvisor_archiveentry pointing at the GitHub releaseSHA512SUMSfile, with an extractor mapping the two tarball hashes tox86_64/aarch64gvisor_runsc,gvisor_containerd_shim) into onegvisor_archivedownload withunarchive: truerunscandcontainerd-shim-runsc-v1from the extractedgvisor/directory in the gvisor rolegvisor_archive_checksumsfor20260817.0(amd64/arm64); old per-arch checksum variables remain as aliases so existing data keeps resolvingWhich issue(s) this PR fixes
Fixes #13460
Special notes for your reviewer
SHA512SUMSis fetched fromgithub.com/google/gvisor/releases/download/release-{version}/SHA512SUMS; releases only exist from20260817.0onward, so older versions keep the legacy data inchecksums.ymluntouched._get_hash_by_archformats the URL withos=linuxbut the new URL only usesversion, which is fine (extra kwargs ignored by.format).checksums.ymlwithout error (GraphQL rate-limit logs shown below).Does your PR introduce a user-facing change?