Skip to content

kata: templatize some qemu config variables - #13422

Open
shaleenbathla wants to merge 1 commit into
kubernetes-sigs:masterfrom
shaleenbathla:kata/qemu-templatize
Open

kata: templatize some qemu config variables#13422
shaleenbathla wants to merge 1 commit into
kubernetes-sigs:masterfrom
shaleenbathla:kata/qemu-templatize

Conversation

@shaleenbathla

Copy link
Copy Markdown
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:

  • default_maxmemory is hardcoded to 0, which resolves to host total RAM and QEMU attempts hotplugging memory up to host RAM, resulting in "hotplug memory error: ENOENT"
  • virtio_extra_args: on RHEL8, we need to set sandbox=chroot as some syscalls arent supported by that kernel
  • create_container_timeout: good to have as configurable in case we want to reduce it and error out early.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kata(qemu): make create_container_timeout, default_maxmemory, virtiofs_extra_args configurable

Make default_maxmemory, virtio_fs_extra_args and create_container_timeout
configurable via role defaults instead of being hardcoded in the qemu
configuration template.

Signed-off-by: Shaleen Bathla <shaleen.bathla@servicenow.com>
@kubernetes-prow kubernetes-prow Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 20, 2026
@kubernetes-prow
kubernetes-prow Bot requested review from VannTen and tico88612 August 20, 2026 07:42
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @shaleenbathla. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shaleenbathla
Once this PR has been reviewed and has the lgtm label, please assign yankay for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yankay

yankay commented Aug 25, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 25, 2026
@tico88612

Copy link
Copy Markdown
Member

I'd prefer to get the Kata Containers tests back up and running first before adding the PRs for subsequent versions; otherwise, we won't be able to verify if the changes actually work.

@VannTen

VannTen commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

#13452 @tico88612 if you meant this one it's now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants