kata: templatize some qemu config variables - #13422
Conversation
Make default_maxmemory, virtio_fs_extra_args and create_container_timeout configurable via role defaults instead of being hardcoded in the qemu configuration template. Signed-off-by: Shaleen Bathla <shaleen.bathla@servicenow.com>
|
Hi @shaleenbathla. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shaleenbathla The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/ok-to-test |
|
I'd prefer to get the Kata Containers tests back up and running first before adding the PRs for subsequent versions; otherwise, we won't be able to verify if the changes actually work. |
|
#13452 @tico88612 if you meant this one it's now merged. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: