-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add some complete samples for node_labels and dynamic vars render by inventory group #11788
Conversation
Welcome @kelein! |
Hi @kelein. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/label ci-short
inventory/sample/inventory.ini
Outdated
[kube_control_plane:vars] | ||
node_labels={"node-role.kubernetes.io/master":"yes","role":"master"} | ||
|
||
[common_cpu_nodes:vars] | ||
node_labels={"node-role.kubernetes.io/worker":"yes","role":"worker","gpu":"no"} | ||
|
||
[nvidia_gpu_nodes:vars] | ||
node_labels={"node-role.kubernetes.io/worker":"yes","role":"worker","gpu":"yes"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should rather be in as a comment in the default section where node_labels is defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have write a example in docs/ansible/vars.md
to describe how to set labels in inventory.ini
format, do this way feasible ?
inventory/sample/inventory.ini
Outdated
[kube_node:children] | ||
common_cpu_nodes | ||
nvidia_gpu_nodes | ||
|
||
|
||
[common_cpu_nodes] | ||
node6 | ||
node7 | ||
|
||
|
||
[nvidia_gpu_nodes] | ||
node4 | ||
node5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvidia_gpu_nodes are a pretty specific usecases, which should not be in the basic example inventory.
@@ -21,7 +21,7 @@ kube_version: v1.31.3 | |||
|
|||
# Where the binaries will be downloaded. | |||
# Note: ensure that you've enough disk space (about 1G) | |||
local_release_dir: "/tmp/releases" | |||
local_release_dir: "/tmp/releases-{{ kube_version }}" | |||
# Random shifts for retrying failed ops like pushing/downloading |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific reason for this ? Does not seem needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have installed k8s with different version many times which the local release dir stored so many binary files of many version. Just only applies to my scene, I had rollback this change.
You'll need to remove your merge commit by rebasing as indicated by the CI robot.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kelein The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please try to avoid closing and reopening new PRs, and rebase your branch when needed instead. Otherwise we lose the history and the context.
|
What type of PR is this?
/kind documentation
What this PR does / why we need it:
node_labels
var defination to label or taint nodescontainerd_default_runtime
var by inventory groupcontainerd_additional_runtimes
of nvidianvidia_gpu_nodes
var by inventory group'local_release_dir
var with kube_version suffixWhich issue(s) this PR fixes:
NONE
Special notes for your reviewer:
node_labels
definationcontainerd_default_runtime
nvidia_gpu_nodes
varDoes this PR introduce a user-facing change?: