✨ (go/v4) add e2e build tag to prevent accidental execution of end-to-end tests #4946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
camilamacedo86
force-pushed
the
e2e-test-add-tags
branch
2 times, most recently
from
d0157a0 to
d90cbbd
Compare
camilamacedo86
changed the title
camilamacedo86
force-pushed
the
e2e-test-add-tags
branch
from
d90cbbd to
bace4fe
Compare
camilamacedo86
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
applejag
approved these changes
Jul 20, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: applejag, camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
camilamacedo86
force-pushed
the
e2e-test-add-tags
branch
3 times, most recently
from
88d1b12 to
535aa82
Compare
camilamacedo86
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
e2e-test-add-tags
branch
from
535aa82 to
990a2a3
Compare
camilamacedo86
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some users unintentionally ran E2E tests against production environments by using
go test ./.... This can lead to dangerous side effects like uninstalling Cert Manager or modifying shared clusters.What’s Changed
//go:build e2etags to all E2E test files.Makefileto run E2E tests with-tags=e2e.How to Run E2E Tests Now
You must explicitly pass the tag:
Result
E2E tests are no longer included in default
go test ./...runs, reducing risk of accidental execution.Closes: #4116
c/c @applejag