Use Expectations from awslabs/operatorpkg and remove duplicate expect…

[jeevanpuchakay]

Fixes 1348

Description

• Using expectations from operatorpkg so that we can avoid duplication at multiple places.
• Changing only one expectation ExpectCleanedUp from pkg/controllers/disruption/suite_test.go as part of this PR to align the overall change with reviewers before creating a bigger PR.

Issue tracker

• Migrate Ginkgo Expectations to operatorpkg #1348

How was this change tested?

• Ran tests from VS code and it passed

[k8s-ci-robot]

Hi @jeevanpuchakay. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jeevanpuchakay]

Unclear why are the presubmit workflows failing

[coveralls]

Pull Request Test Coverage Report for Build 12612108378

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage remained the same at 81.305%

---

Files with Coverage Reduction	New Missed Lines	%
pkg/test/expectations/expectations.go	2	94.81%

Totals
Change from base Build 12587311661:	0.0%
Covered Lines:	9094
Relevant Lines:	11185

---

💛 - Coveralls

[jeevanpuchakay]

Also left a comment on original issue, reviewer can take a look at that as well #1348 (comment)

[engedaam]

/lgtm

[engedaam]

/ok-to-test

[jonathan-innis]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeevanpuchakay, jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jonathan-innis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment