Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add initialized label key to metric labels #1868

Merged

Conversation

jonathan-innis
Copy link
Member

@jonathan-innis jonathan-innis commented Dec 5, 2024

Fixes #N/A

Description

Add the karpenter_sh_initialized label key to our metric label dimensions for nodes

New Metrics

➜  karpenter-provider-aws git:(main) curl localhost:8080/metrics | grep node_ | grep status_condition | grep ip-192-168-190-46.us-west-2.compute.internal
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0operator_node_status_condition_count{karpenter_k8s_aws_ec2nodeclass="default",karpenter_sh_initialized="true",karpenter_sh_nodepool="default",name="ip-192-168-190-46.us-west-2.compute.internal",namespace="",reason="KubeletHasNoDiskPressure",status="False",type="DiskPressure"} 1
operator_node_status_condition_count{karpenter_k8s_aws_ec2nodeclass="default",karpenter_sh_initialized="true",karpenter_sh_nodepool="default",name="ip-192-168-190-46.us-west-2.compute.internal",namespace="",reason="KubeletHasSufficientMemory",status="False",type="MemoryPressure"} 1
operator_node_status_condition_count{karpenter_k8s_aws_ec2nodeclass="default",karpenter_sh_initialized="true",karpenter_sh_nodepool="default",name="ip-192-168-190-46.us-west-2.compute.internal",namespace="",reason="KubeletHasSufficientPID",status="False",type="PIDPressure"} 1
operator_node_status_condition_count{karpenter_k8s_aws_ec2nodeclass="default",karpenter_sh_initialized="true",karpenter_sh_nodepool="default",name="ip-192-168-190-46.us-west-2.compute.internal",namespace="",reason="KubeletReady",status="True",type="Ready"} 1
100 2859k    0 2859k    0     0  4625k      0 --:--:-- --:--:-- --:--:-- 4626k
operator_node_status_condition_current_status_seconds{karpenter_k8s_aws_ec2nodeclass="default",karpenter_sh_initialized="true",karpenter_sh_nodepool="default",name="ip-192-168-190-46.us-west-2.compute.internal",namespace="",reason="KubeletHasNoDiskPressure",status="False",type="DiskPressure"} 50796.788685291
operator_node_status_condition_current_status_seconds{karpenter_k8s_aws_ec2nodeclass="default",karpenter_sh_initialized="true",karpenter_sh_nodepool="default",name="ip-192-168-190-46.us-west-2.compute.internal",namespace="",reason="KubeletHasSufficientMemory",status="False",type="MemoryPressure"} 50796.788648082
operator_node_status_condition_current_status_seconds{karpenter_k8s_aws_ec2nodeclass="default",karpenter_sh_initialized="true",karpenter_sh_nodepool="default",name="ip-192-168-190-46.us-west-2.compute.internal",namespace="",reason="KubeletHasSufficientPID",status="False",type="PIDPressure"} 50796.788730003
operator_node_status_condition_current_status_seconds{karpenter_k8s_aws_ec2nodeclass="default",karpenter_sh_initialized="true",karpenter_sh_nodepool="default",name="ip-192-168-190-46.us-west-2.compute.internal",namespace="",reason="KubeletReady",status="True",type="Ready"} 50789.788765247

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 5, 2024
@k8s-ci-robot k8s-ci-robot requested a review from tallaxes December 5, 2024 22:02
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 5, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12188792917

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 80.456%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/controllers.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/provisioning/scheduling/nodeclaim.go 3 85.64%
pkg/controllers/provisioning/scheduling/preferences.go 7 86.52%
Totals Coverage Status
Change from base Build 12185889830: -0.06%
Covered Lines: 8888
Relevant Lines: 11047

💛 - Coveralls

Copy link
Contributor

@rschalo rschalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis, rschalo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d3907af into kubernetes-sigs:main Dec 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants