Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add pod scheduled prometheus label #1836

Merged

Conversation

jonathan-innis
Copy link
Member

Fixes #N/A

Description

Add scheduled prometheus label for the pod_state metrics

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 24, 2024
@jonathan-innis jonathan-innis force-pushed the add-pod-scheduled-label branch from c3732d8 to a8277dc Compare November 24, 2024 08:45
@jmdeal
Copy link
Member

jmdeal commented Nov 24, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11994676866

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 81.048%

Files with Coverage Reduction New Missed Lines %
pkg/test/expectations/expectations.go 4 94.34%
Totals Coverage Status
Change from base Build 11993257040: 0.003%
Covered Lines: 8844
Relevant Lines: 10912

💛 - Coveralls

@k8s-ci-robot k8s-ci-robot merged commit 63a72bf into kubernetes-sigs:main Nov 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants