chore: fix nodeclaim going unknown during instance termination

[rschalo]

Fixes #N/A

Description
This fixes an issue where during deletion, the generation of an object is incremented and then the status condition controller we use transitions the root condition of the object to Unknown due to a mismatch in lastSeenGeneration and currentGeneration for other status conditions.

How was this change tested?
Unit tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[k8s-ci-robot]

Hi @rschalo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jonathan-innis]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis, rschalo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jonathan-innis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jonathan-innis]

/hold Testing needed for this change

[coveralls]

Pull Request Test Coverage Report for Build 11962627310

Details

• 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.05%) to 81.072%

---

Files with Coverage Reduction	New Missed Lines	%
pkg/test/expectations/expectations.go	2	94.73%

Totals
Change from base Build 11960172117:	0.05%
Covered Lines:	8746
Relevant Lines:	10788

---

💛 - Coveralls

[jmdeal]

/unhold discussed offline, we're going to add more holistic testing in a follow-up.

[jmdeal]

/ok-to-test
/hold cancel