-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove Eventual Disruption cloud provider interface #1832
chore: Remove Eventual Disruption cloud provider interface #1832
Conversation
/hold |
Pull Request Test Coverage Report for Build 11962349310Details
💛 - Coveralls |
c84ee73
to
0a5a607
Compare
0a5a607
to
4865b08
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, lgtm.
Excited to get the convo started around this area, and ensure we get the best working solution implemented :)
FYI: changes look good, but for pkg/controllers/disruption/drift_test.go
I only did a quick pass over it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: charliedmcb, engedaam, jonathan-innis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Fixes #N/A
Description
How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.