Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Limit Node Repair based by Nodepool #1831

Merged
merged 2 commits into from
Nov 26, 2024
Merged

chore: Limit Node Repair based by Nodepool #1831

merged 2 commits into from
Nov 26, 2024

Conversation

engedaam
Copy link
Contributor

Fixes #N/A

Description

  • Limit node repair on a nodepool, more then 20% nodes are considered unhealthy based on the cloud provider repair policy. Karpenter will validate for each nodepool

How was this change tested?

  • make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 20, 2024
@engedaam engedaam changed the title chore: Limit node repair based by nodepool chore: Limit Node Repair based by Nodepool Nov 20, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 20, 2024
@engedaam engedaam force-pushed the limit-by-nodepool branch 3 times, most recently from a10ef64 to 86f44f4 Compare November 20, 2024 19:00
@coveralls
Copy link

coveralls commented Nov 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12020269313

Details

  • 34 of 69 (49.28%) changed or added relevant lines in 3 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 80.844%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/controllers.go 0 1 0.0%
pkg/controllers/node/health/events.go 0 10 0.0%
pkg/controllers/node/health/controller.go 34 58 58.62%
Files with Coverage Reduction New Missed Lines %
pkg/utils/termination/termination.go 2 92.31%
pkg/test/expectations/expectations.go 2 94.73%
Totals Coverage Status
Change from base Build 11994809568: -0.2%
Covered Lines: 8875
Relevant Lines: 10978
💛 - Coveralls

jmdeal
jmdeal reviewed Nov 22, 2024
View reviewed changes
pkg/controllers/node/health/controller.go Outdated Show resolved Hide resolved
pkg/controllers/node/health/controller.go Outdated Show resolved Hide resolved
pkg/controllers/node/health/controller.go Outdated Show resolved Hide resolved
pkg/controllers/node/health/controller.go Show resolved Hide resolved
pkg/controllers/node/health/controller.go Outdated Show resolved Hide resolved
pkg/controllers/node/health/controller.go Outdated Show resolved Hide resolved
pkg/controllers/node/health/suite_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 22, 2024
@jmdeal
Copy link
Member

jmdeal commented Nov 22, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2024
jonathan-innis
jonathan-innis reviewed Nov 24, 2024
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need more observability around this if we are going to be blocking action that a user would expect would happen

pkg/controllers/node/health/controller.go Outdated Show resolved Hide resolved
pkg/controllers/node/health/controller.go Outdated Show resolved Hide resolved
pkg/controllers/node/health/controller.go Outdated Show resolved Hide resolved
pkg/controllers/node/health/controller.go Outdated Show resolved Hide resolved
pkg/controllers/node/health/controller.go Outdated Show resolved Hide resolved
pkg/controllers/node/health/controller.go Outdated Show resolved Hide resolved
pkg/controllers/node/health/controller.go Outdated Show resolved Hide resolved
pkg/controllers/node/health/suite_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 25, 2024
@engedaam engedaam force-pushed the limit-by-nodepool branch 2 times, most recently from 56ccc4e to 3a2ea26 Compare November 25, 2024 20:52
jonathan-innis
jonathan-innis reviewed Nov 25, 2024
View reviewed changes
pkg/apis/v1/nodepool_status.go Outdated Show resolved Hide resolved
pkg/controllers/node/health/controller.go Outdated Show resolved Hide resolved
pkg/controllers/node/health/controller.go Outdated Show resolved Hide resolved
pkg/controllers/node/health/controller.go Outdated Show resolved Hide resolved
pkg/controllers/node/health/controller.go Outdated Show resolved Hide resolved
pkg/controllers/node/health/controller.go Outdated Show resolved Hide resolved
pkg/controllers/node/health/controller.go Outdated Show resolved Hide resolved
pkg/controllers/node/health/controller.go Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the limit-by-nodepool branch 3 times, most recently from 6fe7a74 to b549194 Compare November 25, 2024 22:53
jonathan-innis
jonathan-innis reviewed Nov 26, 2024
View reviewed changes
pkg/apis/v1/nodepool_status.go Outdated Show resolved Hide resolved
pkg/controllers/node/health/controller.go Show resolved Hide resolved
pkg/controllers/node/health/controller.go Outdated Show resolved Hide resolved
pkg/controllers/node/health/controller.go Outdated Show resolved Hide resolved
pkg/controllers/node/health/controller.go Outdated Show resolved Hide resolved
pkg/controllers/node/health/events.go Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the limit-by-nodepool branch 2 times, most recently from 1b1c985 to 049d78e Compare November 26, 2024 07:59
@engedaam engedaam force-pushed the limit-by-nodepool branch 3 times, most recently from 89b60b0 to 093a3ce Compare November 26, 2024 08:11
jonathan-innis
jonathan-innis approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: engedaam, jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6efbae4 into kubernetes-sigs:main Nov 26, 2024
12 checks passed
@engedaam engedaam deleted the limit-by-nodepool branch December 11, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdeal jmdeal jmdeal left review comments

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@jmdeal jmdeal

@jonathan-innis jonathan-innis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@engedaam @coveralls @jmdeal @k8s-ci-robot @jonathan-innis