-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Cache the pod request calculation in memory #1825
perf: Cache the pod request calculation in memory #1825
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonathan-innis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 11883702745Details
💛 - Coveralls |
4f33b85
to
041e1f9
Compare
4f36e52
to
36f98ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold |
36f98ee
to
5500a8d
Compare
/lgtm |
Fixes #N/A
Description
Cache pod request calculations in memory during scheduling -- this prevents us from calling requests.RequestsForPods a ton of times during the scheduling simulation which causes us to reconstruct the requests. We can calculate this once at the beginning of the scheduling simulation and then just reached for the pre-computed cached value anytime we are trying to use a pod's requests
How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.