-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add consolidation policies for WhenCheaper, WhenUnderutilizedOrCheaper #1429
feat: Add consolidation policies for WhenCheaper, WhenUnderutilizedOrCheaper #1429
Conversation
…Cheaper Signed-off-by: Cameron McAvoy <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cnmcavoy The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 9961312317Details
💛 - Coveralls |
Can you write an RFC: https://karpenter.sh/docs/contributing/design-guide/? |
RFC: #1433 |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
Fixes #1430
The motivation is to allow cluster operators to configure some nodepools for single-node consolidation (and emptiness), and configure some nodepools for multi-node consolidation, but not single-node consolidation. New enum values for the
consolidationPolicy
make this possible.Description
Adds two new consolidation policy enum values:
WhenCheaper
WhenUnderutilizedOrCheaper
Changes the semantics of the existing consolidation policy enum value:
WhenUnderutilized
WhenUnderutilizedOrCheaper
becomes the new default.WhenUnderutilizedOrCheaper
is the same asWhenUnderutilized
today. It functions the same, it is just a new name.WhenUnderutilized
semantics changes to only allow emptiness or multi-node consolidation to occur for a nodepool.WhenCheaper
only allows emptiness or single-node consolidation to occur for a nodepool.How was this change tested?
Tested in a kind cluster and with
make presubmit
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.