Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding print columns for v1 NodePool #1365

Merged
merged 10 commits into from
Jul 3, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Jun 28, 2024

Fixes #N/A

Description

  • Old Printer Column
NAME     NODECLASS   WEIGHT
default  default     100
  • New Printer Column
NAME              NODECLASS   NODES   READY   AGE   WEIGHT   CPU   MEMORY
default-v1        default     10              22h   45       20    19297984Ki

How was this change tested?

  • manually tested

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 28, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 28, 2024
@coveralls
Copy link

coveralls commented Jun 28, 2024

Pull Request Test Coverage Report for Build 9709282006

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 78.3%

Files with Coverage Reduction New Missed Lines %
pkg/controllers/provisioning/scheduling/nodeclaim.go 2 89.13%
pkg/controllers/node/termination/terminator/eviction.go 2 89.09%
pkg/controllers/node/termination/controller.go 2 59.81%
Totals Coverage Status
Change from base Build 9704123132: -0.03%
Covered Lines: 8667
Relevant Lines: 11069

💛 - Coveralls

@engedaam engedaam marked this pull request as ready for review June 28, 2024 16:18
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2024
pkg/apis/v1/nodepool_status.go Outdated Show resolved Hide resolved
pkg/apis/v1beta1/nodepool_status.go Outdated Show resolved Hide resolved
pkg/controllers/nodepool/counter/controller.go Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the print-columns branch 2 times, most recently from bf440f1 to a66e844 Compare June 28, 2024 22:59
@coveralls
Copy link

coveralls commented Jun 28, 2024

Pull Request Test Coverage Report for Build 9719428840

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 78.818%

Totals Coverage Status
Change from base Build 9719097361: 0.02%
Covered Lines: 8603
Relevant Lines: 10915

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 28, 2024

Pull Request Test Coverage Report for Build 9719439493

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 78.754%

Files with Coverage Reduction New Missed Lines %
pkg/controllers/provisioning/scheduling/preferences.go 7 86.67%
Totals Coverage Status
Change from base Build 9719097361: -0.05%
Covered Lines: 8596
Relevant Lines: 10915

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 1, 2024

Pull Request Test Coverage Report for Build 9738185578

Details

  • 4 of 6 (66.67%) changed or added relevant lines in 1 file are covered.
  • 22 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.07%) to 78.73%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/nodepool/counter/controller.go 4 6 66.67%
Files with Coverage Reduction New Missed Lines %
pkg/test/expectations/expectations.go 2 93.69%
pkg/controllers/provisioning/scheduling/nodeclaim.go 2 89.13%
pkg/controllers/provisioning/scheduling/preferences.go 7 86.67%
pkg/controllers/nodepool/counter/controller.go 11 65.08%
Totals Coverage Status
Change from base Build 9721804824: -0.07%
Covered Lines: 8591
Relevant Lines: 10912

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 1, 2024

Pull Request Test Coverage Report for Build 9738191505

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 78.825%

Totals Coverage Status
Change from base Build 9721804824: 0.03%
Covered Lines: 8599
Relevant Lines: 10909

💛 - Coveralls

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 2, 2024
pkg/controllers/nodepool/counter/controller.go Outdated Show resolved Hide resolved
pkg/controllers/nodepool/counter/controller.go Outdated Show resolved Hide resolved
pkg/controllers/nodepool/counter/controller.go Outdated Show resolved Hide resolved
pkg/controllers/nodepool/counter/suite_test.go Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9765417377

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 173 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.2%) to 78.639%

Files with Coverage Reduction New Missed Lines %
pkg/controllers/node/termination/controller.go 2 59.81%
pkg/controllers/provisioning/scheduling/preferences.go 7 86.67%
pkg/apis/v1/nodepool.go 20 67.86%
pkg/apis/v1/zz_generated.deepcopy.go 144 24.0%
Totals Coverage Status
Change from base Build 9721804824: -0.2%
Covered Lines: 8585
Relevant Lines: 10917

💛 - Coveralls

Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: engedaam, jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit 715c446 into kubernetes-sigs:main Jul 3, 2024
13 checks passed
BEvgeniyS pushed a commit to BEvgeniyS/karpenter that referenced this pull request Jul 5, 2024
@engedaam engedaam deleted the print-columns branch July 5, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants