BREAKING: Convert knative status conditions to operatorpkg #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
approved
jonathan-innis
force-pushed
the
status-conditions-operatorpkg
branch
3 times, most recently
from
25e826b to
fa78114
Compare
k8s-ci-robot
added
size/XXL
jonathan-innis
force-pushed
the
status-conditions-operatorpkg
branch
from
fa78114 to
b7d5461
Compare
k8s-ci-robot
added
size/XL
jonathan-innis
force-pushed
the
status-conditions-operatorpkg
branch
4 times, most recently
from
afd44fc to
0eb0fdf
Compare
jonathan-innis
force-pushed
the
status-conditions-operatorpkg
branch
from
0eb0fdf to
adbf30f
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Pull Request Test Coverage Report for Build 9065520113Details
💛 - Coveralls |
jonathan-innis
force-pushed
the
status-conditions-operatorpkg
branch
2 times, most recently
from
dd6cefe to
2fa50b0
Compare
jigisha620
reviewed
May 13, 2024
jonathan-innis
force-pushed
the
status-conditions-operatorpkg
branch
2 times, most recently
from
2e0c58e to
69bd6a7
Compare
jonathan-innis
force-pushed
the
status-conditions-operatorpkg
branch
3 times, most recently
from
b86052f to
383d4c3
Compare
jigisha620
reviewed
May 13, 2024
jonathan-innis
force-pushed
the
status-conditions-operatorpkg
branch
from
383d4c3 to
07b31ab
Compare
|
@jigisha620: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jigisha620, jonathan-innis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jonathan-innis
changed the title
k8s-ci-robot
added
the
lgtm
jonathan-innis
added a commit
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
This change converts knative's status conditions to operatorpkg
status.Conditionspackage. This allows us to onboard to things likestatus.Controllerthat will give us additional metrics on our status conditions for free.BREAKING: The
severityfield is removed from the conditions object. This field is not present inmetav1.Conditionbut was present in the knative representation.How was this change tested?
make presubmitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.