Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Karpenter v1 API & Roadmap Proposal #1222

Merged
merged 10 commits into from
Jul 30, 2024

Conversation

jonathan-innis
Copy link
Member

Fixes #N/A

Description

This proposes the Karpenter stable v1 API and Roadmap. The Roadmap includes features and cleanup tasks that we need to complete before reaching v1.

How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from jackfrancis and jmdeal May 1, 2024 23:49
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 1, 2024
@jonathan-innis jonathan-innis force-pushed the v1-rfc branch 3 times, most recently from 3a913ef to b63e352 Compare May 1, 2024 23:51
@coveralls
Copy link

coveralls commented May 2, 2024

Pull Request Test Coverage Report for Build 10154303822

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 78.128%

Files with Coverage Reduction New Missed Lines %
pkg/controllers/node/termination/controller.go 2 62.4%
Totals Coverage Status
Change from base Build 10153606152: 0.02%
Covered Lines: 8855
Relevant Lines: 11334

💛 - Coveralls

designs/v1-api.md Outdated Show resolved Hide resolved
Copy link
Member

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this proposal sir!

Documentation: Does it make sense to make the azure + aws documentation unification effort happen alongside v1?

designs/v1-roadmap.md Show resolved Hide resolved
designs/v1-roadmap.md Outdated Show resolved Hide resolved
designs/v1-roadmap.md Outdated Show resolved Hide resolved
designs/v1-api.md Show resolved Hide resolved
designs/v1-roadmap.md Show resolved Hide resolved
designs/v1-roadmap.md Outdated Show resolved Hide resolved
designs/v1-roadmap.md Show resolved Hide resolved
@Bryce-Soghigian
Copy link
Member

Musing for v1:

E2E Testing for Core: Would there be an interest in testing core via e2es with kwok? There are some bits of functionality that change a lot of behavior in the v1 proposal like the ConsolidateAfter for the WhenUnderutilized consolidation policy. Would it be something we want to take on to have some of the e2e tests go from providers to also being included in core? We should take some additional testing steps for ensuring stability in core releases since we are moving to v1.

We still should run and develop e2es for our providers, but some of the functionality like consolidation is driven by core, mostly. Given our providers are both on the latest version of core so you can bump the version with tags to test things there as well. But having some e2es gate consolidation and scheduling etc would be useful for gating code.

We can even write them to run on multiple managed k8s services (AKS, EKS) with kwok as the cloud provider in multiple clouds(AWS, Azure)? I haven't played enough with kwok to see if something like that would work, but supposedly we could, right?

designs/v1-api.md Show resolved Hide resolved
designs/v1-api.md Show resolved Hide resolved
designs/v1-api.md Outdated Show resolved Hide resolved
designs/v1-api.md Show resolved Hide resolved
designs/v1-api.md Show resolved Hide resolved
designs/v1-api.md Show resolved Hide resolved
designs/v1-api.md Outdated Show resolved Hide resolved
designs/v1-roadmap.md Outdated Show resolved Hide resolved
@sftim
Copy link

sftim commented May 2, 2024

If we want to announce v1, the Kubernetes blog team can help with that.

@jonathan-innis
Copy link
Member Author

jonathan-innis commented May 5, 2024

E2E Testing for Core: Would there be an interest in testing core via e2es with kwok

I didn't want to directly couple it to v1 (because I don't think I view it as a blocking change) but there's a lot of contribution work that's happening between some folks on the AWS side and @njtran to start getting more extensive testing and benchmarking with Kwok. I can imagine that this work is going to happen in parallel with v1 but I don't personally want to block on it since it's going to be a long-poll to move over a lot of the testing that's currently sitting in the providers into the upstream codebase.

@jonathan-innis
Copy link
Member Author

Does it make sense to make the azure + aws documentation unification effort happen alongside v1

This another one that has unknown timelines in my mind and I don't think has any direct impact to users if it comes after v1 (at least from a breaking change perspective). I'd rather just keep working on this effort and not view it as a blocking action for the v1 release.

designs/v1-api.md Show resolved Hide resolved
designs/v1-api.md Show resolved Hide resolved
designs/v1-api.md Outdated Show resolved Hide resolved
designs/v1-api.md Outdated Show resolved Hide resolved
designs/v1-roadmap.md Outdated Show resolved Hide resolved
designs/v1-roadmap.md Outdated Show resolved Hide resolved
designs/v1-roadmap.md Show resolved Hide resolved
Copy link

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 25, 2024
@jmdeal
Copy link
Member

jmdeal commented May 25, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 25, 2024
Copy link

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 18, 2024
@jonathan-innis jonathan-innis force-pushed the v1-rfc branch 2 times, most recently from b22bd49 to 1a02d02 Compare July 24, 2024 23:06
@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 25, 2024
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small nits, and questions

designs/v1-api.md Outdated Show resolved Hide resolved
designs/v1-api.md Outdated Show resolved Hide resolved
designs/v1-api.md Outdated Show resolved Hide resolved
designs/v1-api.md Outdated Show resolved Hide resolved
designs/v1-api.md Outdated Show resolved Hide resolved
designs/v1-roadmap.md Show resolved Hide resolved
designs/v1-roadmap.md Outdated Show resolved Hide resolved
@jonathan-innis jonathan-innis force-pushed the v1-rfc branch 2 times, most recently from 9d8fccb to fe95bd1 Compare July 29, 2024 23:35
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits

designs/v1-api.md Show resolved Hide resolved
designs/v1-api.md Show resolved Hide resolved
@jonathan-innis jonathan-innis force-pushed the v1-rfc branch 2 times, most recently from 41400fa to 2179fd1 Compare July 30, 2024 00:22
designs/v1-roadmap.md Outdated Show resolved Hide resolved
@engedaam
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit 40c4320 into kubernetes-sigs:main Jul 30, 2024
11 checks passed
BEvgeniyS pushed a commit to BEvgeniyS/karpenter that referenced this pull request Sep 16, 2024
Co-authored-by: Reed Schalo <[email protected]>
Co-authored-by: Amanuel Engeda <[email protected]>
Co-authored-by: Jason Deal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.