chore: Wait for instance termination before deleting nodeclaim

[jigisha620]

Fixes #N/A

Description
Finalizers on nodeClaim and node should not be removed until the underlying instance is deleted to avoid leaking any resources. The current approach relies on retryable error being emitted by cloudProvider.Delete() and continues reconciliation until this error is received. However, that is not an ideal approach. When this approach was tested for AWS provider we found that some instances could take too long to delete.Hence in this PR, instead a status condition terminating is added on nodeclaim and if the status exists then we call cloudProvider.Get() to check if the instance is terminated. If it is terminated, then we can remove finalizer from the nodeClaim.

How was this change tested?
Tested on my local cluster and ran unit tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[k8s-ci-robot]

Hi @jigisha620. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[coveralls]

Pull Request Test Coverage Report for Build 9487162594

Details

• 75 of 95 (78.95%) changed or added relevant lines in 7 files are covered.
• 9 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.06%) to 81.336%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/utils/node/node.go	4	6	66.67%
pkg/controllers/nodeclaim/termination/controller.go	17	21	80.95%
pkg/utils/termination/termination.go	24	29	82.76%
pkg/controllers/node/termination/controller.go	13	22	59.09%

Files with Coverage Reduction	New Missed Lines	%
pkg/test/expectations/expectations.go	2	93.69%
pkg/cloudprovider/types.go	7	85.8%

Totals
Change from base Build 9486831375:	-0.06%
Covered Lines:	8306
Relevant Lines:	10212

---

💛 - Coveralls

[jonathan-innis]

Really nice work! I didn't look at the testing, but overall the core code looks good. This is also going to be amazing for measuring how long the instance terminations take if we can matter the status transition time -> delete call time. Does it make sense to add a metric to measure this before actually removing the finalizer?

[engedaam]

Nice work!

[jonathan-innis]

I think for all of the testing, I would tidy up the description of the test. I should be able to read the description of the test and immediately reason about what it should be doing and validating without having to read through the details of the test itself

[jonathan-innis]

/lgtm
/approve

[jonathan-innis]

/hold Waiting for the E2E tests in the downstream repo in the AWS Provider to pass with these new changes

[jonathan-innis]

/unhold Tests passed and are running in a reasonable time. This should be GTG

[jigisha620]

/unhold

[jonathan-innis]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jigisha620, jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jonathan-innis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment