Skip to content

Commit

Permalink
chore: updates for v0.27.7 release (#760)
Browse files Browse the repository at this point in the history
  • Loading branch information
jmdeal authored Nov 6, 2023
1 parent 5444150 commit 7dfb9e0
Show file tree
Hide file tree
Showing 9 changed files with 8 additions and 12 deletions.
2 changes: 1 addition & 1 deletion hack/toolchain.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ tools() {
go install sigs.k8s.io/controller-tools/cmd/[email protected]
go install github.com/sigstore/cosign/cmd/[email protected]
go install github.com/gohugoio/[email protected]+extended
go install golang.org/x/vuln/cmd/govulncheck@v0.0.0-20230215172424-8fb696828224
go install golang.org/x/vuln/cmd/govulncheck@latest
go install github.com/onsi/ginkgo/v2/ginkgo@latest

if ! echo "$PATH" | grep -q "${GOPATH:-undefined}/bin\|$HOME/go/bin"; then
Expand Down
3 changes: 1 addition & 2 deletions pkg/apis/crds/karpenter.sh_machines.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.11.3
creationTimestamp: null
controller-gen.kubebuilder.io/version: v0.13.0
name: machines.karpenter.sh
spec:
group: karpenter.sh
Expand Down
3 changes: 1 addition & 2 deletions pkg/apis/crds/karpenter.sh_provisioners.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.11.3
creationTimestamp: null
controller-gen.kubebuilder.io/version: v0.13.0
name: provisioners.karpenter.sh
spec:
group: karpenter.sh
Expand Down
1 change: 0 additions & 1 deletion pkg/apis/settings/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/apis/v1alpha5/provisioner_validation.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ func (s *ProvisionerSpec) validateTTLSecondsAfterEmpty() (errs *apis.FieldError)
}

// Validate the constraints
func (s *ProvisionerSpec) Validate(ctx context.Context) (errs *apis.FieldError) {
func (s *ProvisionerSpec) Validate(_ context.Context) (errs *apis.FieldError) {
return errs.Also(
s.validateProvider(),
s.validateLabels(),
Expand Down
1 change: 0 additions & 1 deletion pkg/apis/v1alpha5/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/controllers/deprovisioning/expiration.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ func NewExpiration(clk clock.Clock, kubeClient client.Client, cluster *state.Clu
}

// ShouldDeprovision is a predicate used to filter deprovisionable nodes
func (e *Expiration) ShouldDeprovision(ctx context.Context, c *Candidate) bool {
func (e *Expiration) ShouldDeprovision(_ context.Context, c *Candidate) bool {
// Filter out nodes without the TTL defined or expired.
if c.provisioner == nil || c.provisioner.Spec.TTLSecondsUntilExpired == nil {
return false
Expand Down
2 changes: 1 addition & 1 deletion pkg/controllers/node/drift.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ type Drift struct {
cloudProvider cloudprovider.CloudProvider
}

func (d *Drift) Reconcile(ctx context.Context, provisioner *v1alpha5.Provisioner, node *v1.Node) (reconcile.Result, error) {
func (d *Drift) Reconcile(ctx context.Context, _ *v1alpha5.Provisioner, node *v1.Node) (reconcile.Result, error) {
// If the node is marked as voluntarily disrupted by another controller, do nothing.
val, hasAnnotation := node.Annotations[v1alpha5.VoluntaryDisruptionAnnotationKey]
if hasAnnotation && val != v1alpha5.VoluntaryDisruptionDriftedAnnotationValue {
Expand Down
4 changes: 2 additions & 2 deletions pkg/webhooks/webhooks.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func NewWebhooks() []knativeinjection.ControllerConstructor {
}
}

func NewCRDValidationWebhook(ctx context.Context, w configmap.Watcher) *controller.Impl {
func NewCRDValidationWebhook(ctx context.Context, _ configmap.Watcher) *controller.Impl {
return validation.NewAdmissionController(ctx,
"validation.webhook.karpenter.sh",
"/validate/karpenter.sh",
Expand All @@ -48,7 +48,7 @@ func NewCRDValidationWebhook(ctx context.Context, w configmap.Watcher) *controll
)
}

func NewConfigValidationWebhook(ctx context.Context, cmw configmap.Watcher) *controller.Impl {
func NewConfigValidationWebhook(ctx context.Context, _ configmap.Watcher) *controller.Impl {
return configmaps.NewAdmissionController(ctx,
"validation.webhook.config.karpenter.sh",
"/validate/config.karpenter.sh",
Expand Down

0 comments on commit 7dfb9e0

Please sign in to comment.