-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update k8s to 0.32 apis #738
base: main
Are you sure you want to change the base?
Conversation
@kannon92: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kannon92 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-jobset canceled.
|
Kueue PR: kubernetes-sigs/kueue#3820 |
why not wait for the depbot? |
We turn off dependabot for K8s release changes. It’s enabled for patches for a version. Besides I think K8s bumps require one to generate the manifests in case API changes so it’s better for a manually process. |
@@ -15,24 +15,24 @@ limitations under the License. | |||
package v1alpha2 | |||
|
|||
import ( | |||
"context" | |||
context "context" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please revert all those files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we disagree with this I think we gotta fix this upstream. Otherwise everything someone needs to revert this whenever they do generate.
b6875b0
to
9ea5ff3
Compare
What type of PR is this?
/kind dependency
What this PR does / why we need it:
Bump k8s api to 0.32.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Kueue usually waits until the first patch release of 0.32. We can do the same if we want.
Does this PR introduce a user-facing change?