Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update k8s to 0.32 apis #738

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kannon92
Copy link
Contributor

What type of PR is this?

/kind dependency

What this PR does / why we need it:

Bump k8s api to 0.32.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Kueue usually waits until the first patch release of 0.32. We can do the same if we want.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

@kannon92: The label(s) kind/dependency cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind dependency

What this PR does / why we need it:

Bump k8s api to 0.32.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Kueue usually waits until the first patch release of 0.32. We can do the same if we want.

Does this PR introduce a user-facing change?

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 20, 2024
@k8s-ci-robot k8s-ci-robot requested a review from ahg-g December 20, 2024 22:02
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kannon92
Once this PR has been reviewed and has the lgtm label, please assign danielvegamyhre for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 20, 2024
Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for kubernetes-sigs-jobset canceled.

Name Link
🔨 Latest commit 9ea5ff3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/6769a97a48515d00080dd123

@kannon92
Copy link
Contributor Author

Kueue PR: kubernetes-sigs/kueue#3820

@ahg-g
Copy link
Contributor

ahg-g commented Dec 21, 2024

why not wait for the depbot?

@kannon92
Copy link
Contributor Author

why not wait for the depbot?

We turn off dependabot for K8s release changes. It’s enabled for patches for a version.

Besides I think K8s bumps require one to generate the manifests in case API changes so it’s better for a manually process.

@@ -15,24 +15,24 @@ limitations under the License.
package v1alpha2

import (
"context"
context "context"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please revert all those files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we disagree with this I think we gotta fix this upstream. Otherwise everything someone needs to revert this whenever they do generate.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants