Propagate job labels and annotations #737

imreddy13 · 2024-12-20T19:56:26Z

What type of PR is this?
/kind bug

What this PR does / why we need it:
Addresses a regression introduced by #696 that drops pod labels and annotations.

Which issue(s) this PR fixes:
Fixes #696

Special notes for your reviewer:
Does this PR introduce a user-facing change?
No

linux-foundation-easycla · 2024-12-20T19:56:30Z

The committers listed above are authorized under a signed CLA.

✅ login: imreddy13 (16fb6c6, ab48445, 57c3d66, f72b086, 2006075, 78be53e, 966158b, 4266677, afe64c0, 7f19d38, 4cf06f0, cb97e1b, 4ead912)
✅ login: ahg-g / name: Abdullah Gharaibeh (d54d12c, e4f0707, ca6b6ed, f680882, 8d9d886, ba0068d, 8e983b7, ac94bb4)

k8s-ci-robot · 2024-12-20T19:56:35Z

Welcome @imreddy13!

It looks like this is your first PR to kubernetes-sigs/jobset 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/jobset has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2024-12-20T19:56:35Z

Hi @imreddy13. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

netlify · 2024-12-20T19:56:46Z

✅ Deploy Preview for kubernetes-sigs-jobset ready!

Name	Link
🔨 Latest commit	`cb97e1b`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/677c78bdc0d8c80008304d82
😎 Deploy Preview	https://deploy-preview-737--kubernetes-sigs-jobset.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ahg-g · 2024-12-20T20:00:50Z

/ok-to-test

pkg/controllers/jobset_controller_test.go

kannon92 · 2024-12-20T22:11:59Z

could you squash your commits once you are done with the feedback

ahg-g · 2024-12-20T22:21:43Z

/label tide/merge-method-squash

no need to squash explicitly

pkg/controllers/jobset_controller_test.go

ahg-g · 2024-12-21T02:54:30Z

/lgtm
/approve

k8s-ci-robot · 2024-12-21T02:54:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, imreddy13

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ahg-g]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kannon92 · 2024-12-23T18:19:48Z

/lgtm cancel

@imreddy13 Please fix the verify step.

kannon92 · 2024-12-23T18:28:07Z

pkg/controllers/jobset_controller_test.go

+		replicatedJobName = "replicated-job"
+		jobName           = "test-job"
+		ns                = "default"
+		jobAnnotations    = map[string]string{


Reading #729, are we not expecting top level labels/annotations to propagate down into the Jobs/Pods?

We should maybe comment on that ticket that top-level labels/annotations won't be passed down but they should be set on the Job/Pod?

From the current implementation, only certain top level labels/annotations are explicitly passed down - see https://github.com/kubernetes-sigs/jobset/blob/main/pkg/controllers/jobset_controller.go#L767

So yes I think by design the user needs to set labels on the ReplicatedJob spec in order to be passed down to the Job/Pod. Is my understanding correct @ahg-g ?

ahg-g · 2025-01-07T01:26:23Z

/lgtm

Propagate job labels and annotations

57c3d66

k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 20, 2024

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 20, 2024

k8s-ci-robot requested review from ahg-g and kannon92 December 20, 2024 19:56

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 20, 2024

imreddy13 added 4 commits December 20, 2024 21:43

Modify unit tests

afe64c0

Fix formatting

78be53e

Remove unused annotation from test

4ead912

Fix unit test

2006075

kannon92 reviewed Dec 20, 2024

View reviewed changes

pkg/controllers/jobset_controller_test.go Outdated Show resolved Hide resolved

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 20, 2024

Separate pod and job labels in tests

4cf06f0

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 21, 2024