-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove kube-rbac-proxy #722
Remove kube-rbac-proxy #722
Conversation
✅ Deploy Preview for kubernetes-sigs-jobset canceled.
|
047521a
to
52219cd
Compare
I was able to confirm this works via: apiVersion: v1
kind: Pod
metadata:
name: metrics-consumer
namespace: jobset-system
spec:
# Use the scaffolded service account name to allow authn/authz
serviceAccountName: jobset-controller-manager
containers:
- name: metrics-consumer
image: curlimages/curl:7.78.0
command: ["/bin/sh"]
args:
- "-c"
- >
while true;
do
# Note here that we are passing the token obtained from the ServiceAccount to curl the metrics endpoint
curl -s -k -H "Authorization: Bearer $(cat /var/run/secrets/kubernetes.io/serviceaccount/token)" https://jobset-controller-manager-metrics-service.jobset-system.svc.cluster.local:8443/metrics;
sleep 60;
done When I run this pod, I am able to see that the metrics server is correctly secured. |
52219cd
to
fcc1ca3
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, kannon92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@camilamacedo86 thanks a lot for reviewing kubernetes-sigs/lws#284; do you mind taking a look at this PR? It is already merged, but we can open a followup if there is something here that needs tweaking. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #721
Special notes for your reviewer:
Does this PR introduce a user-facing change?