-
Notifications
You must be signed in to change notification settings - Fork 452
Add access_cfg_file and access_cfg_file_account for token auth #1854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi @joekr. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edit: removed approval until pipeline corrected.
Actually, I just saw the |
access_cfg_file defaults to `$HOME/.oci/config` access_cfg_file_account defaults to `DEFAULT` more details https://developer.hashicorp.com/packer/integrations/hashicorp/oracle/latest/components/builder/oci#authentication-parameters
7d2319f
to
60e9d7e
Compare
I ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: drew-viles The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Change description
Oracle's Packer provider supports security token based auth. Adding these new builder fields allows users to use this.
access_cfg_file
defaults to$HOME/.oci/config
access_cfg_file_account
defaults toDEFAULT
more details https://developer.hashicorp.com/packer/integrations/hashicorp/oracle/latest/components/builder/oci#authentication-parameters
Related issues
Not a current issue open for this.
Additional context
NA