-
Notifications
You must be signed in to change notification settings - Fork 452
Feat add azure arm64 support #1835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat add azure arm64 support #1835
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @natitomattis. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Is this change required for this PR? If not I think it might be best to have it in its own PR so we can specifically call this out in the changelog. Would you mind squashing your commits too please? /ok-to-test |
@natitomattis: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
😞 Looks like we're blocked by this: hashicorp/packer-plugin-azure#526 |
On my environment I've followed the steps described here and I could install it. Probably I'll need to update the installation on this repo as well |
@AverageMarcus Sorry I just saw this comment:
Yes it is required, since the base ARM image doesn't require the pan information. If we add the plan details it fails. |
FYI - we're discussing the issue with the plugin install change on Slack here: https://kubernetes.slack.com/archives/C01E0Q35A8J/p1754927876822259 |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Change description
Add support for Azure Arm64 builds:
Related issues
Additional context