Skip to content

Conversation

natitomattis
Copy link
Contributor

@natitomattis natitomattis commented Aug 11, 2025

Change description

Add support for Azure Arm64 builds:

  • Is this change including a new Provider or a new OS? (y/n) n
  • If yes, has the Provider/OS matrix been updated in the readme? (y/n) n
  • If adding a new provider, are you a representative of that provider? (y/n) n

Related issues

Additional context

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 11, 2025
@k8s-ci-robot k8s-ci-robot requested a review from devigned August 11, 2025 11:04
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mboersma for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 11, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @natitomattis. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 11, 2025
@AverageMarcus
Copy link
Member

Removed support for deprecated azure managed instances learn.microsoft.com/en-us/azure/virtual-machines/migration/migration-managed-image-to-compute-gallery?tabs=portal

Is this change required for this PR? If not I think it might be best to have it in its own PR so we can specifically call this out in the changelog.

Would you mind squashing your commits too please?

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 11, 2025
@k8s-ci-robot
Copy link
Contributor

@natitomattis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azure-sigs 7f930a7 link false /test pull-azure-sigs
pull-azure-vhds 7f930a7 link true /test pull-azure-vhds
pull-packer-validate 7f930a7 link true /test pull-packer-validate

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@AverageMarcus
Copy link
Member

😞 Looks like we're blocked by this: hashicorp/packer-plugin-azure#526

@natitomattis
Copy link
Contributor Author

natitomattis commented Aug 11, 2025

On my environment I've followed the steps described here and I could install it. Probably I'll need to update the installation on this repo as well

@natitomattis
Copy link
Contributor Author

@AverageMarcus Sorry I just saw this comment:

Is this change required for this PR? If not I think it might be best to have it in its own PR so we can specifically call this out in the changelog.

Yes it is required, since the base ARM image doesn't require the pan information. If we add the plan details it fails.

@AverageMarcus
Copy link
Member

FYI - we're discussing the issue with the plugin install change on Slack here: https://kubernetes.slack.com/archives/C01E0Q35A8J/p1754927876822259

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants