frontend: align duration formatting with apimachinery logic#4931
Open
ChayanDass wants to merge 1 commit intokubernetes-sigs:mainfrom
Open
frontend: align duration formatting with apimachinery logic#4931ChayanDass wants to merge 1 commit intokubernetes-sigs:mainfrom
ChayanDass wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ChayanDass The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
…ogic Replace frontend duration formatting with Kubernetes apimachinery-style ShortHumanDuration and HumanDuration behavior for age-related displays.
0141c01 to
f261e44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align frontend duration/age formatting with Kubernetes apimachinery behavior.
Related Issue
Fixes headlamp-k8s/plugins#485 -> duration issue
Changes
humanize-durationbased age formatting infrontend/src/lib/util.ts.ShortHumanDurationfor compact age values.HumanDurationfor slightly more detailed duration values.formatDuration()to use the new internal formatter functions.Why
This makes Age/Duration output consistent with Kubernetes conventions and avoids mismatches in relative time rendering.
Steps to Test
Age(for example Pods, Deployments, Jobs).s,m,h,d,y).Screenshots